[#ZF-4977] SubmitButton labels aren't getting rendered - Zend Framework Issue Tracker

Details

Type: Bug
Status: Resolved
Priority: Major
Resolution: Fixed
Affects Version/s: 1.7.0
Fix Version/s: 1.7.1
Component/s: Zend_Dojo
Labels:
None

Description

I upgraded to the release version of 1.7.0 after using the 1.7.0 RC and noticed a bug right away. SubmitButton labels weren't getting rendered.

It seems that something has changed in the way SubmitButtons are handled internally and the SubmitButton view helper needs to be updated. From the perspective of the SubmitButton view helper, the label is now stored in the $attribs['content'] field, not the $params['label'] field nor $value.

I made a change to line 54 in Zend/Dojo/View/Helper/SubmitButton.php that fixes the issue

$params['label'] = array_key_exists('content', $attribs) ? $attribs['content'] : $value;

The array_key_exists test is probably unnecessary since I noticed $attribs['content'] contains the name of the button if there is no label, but I like to pad my code for unforseen errors & future changes

Issue Links

This issue is duplicated by:
ZF-5016	dojo form buttons: no title shown
ZF-4984	Cant set a label to Zend_Dojo_Form_Element_SubmitButton
ZF-4980	Dojo submit missing text since upgrading from ZF 1.6 to 1.7

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Matthew Weier O'Phinney added a comment - 18/Nov/08 12:31 PM

Fixed in trunk in r12691, and merged to 1.7 release branch in r12692.

Show

Matthew Weier O'Phinney added a comment - 18/Nov/08 12:31 PM Fixed in trunk in r12691, and merged to 1.7 release branch in r12692.

Hide

Permalink

Matthew Weier O'Phinney added a comment - 19/Nov/08 10:26 AM

Just want to note...

Using the form element, you have the following workaround available until you are able to upgrade:

$element->setDijitParam("label", <label value>);

// or, at creation
$form->addElement('SubmitButton', 'submit', array(
    'label' => <label value>,
    'dijitParams' => array('label' => <label value>),
));

In the view helper, specify a label parameter in the dijitParams argument:

$view->submitButton('submit', 'Label', array('label' => 'Label'));

If you specify both, your code will continue to work in the future as well.

Show

Matthew Weier O'Phinney added a comment - 19/Nov/08 10:26 AM Just want to note... Using the form element, you have the following workaround available until you are able to upgrade:

$element->setDijitParam("label", <label value>);

// or, at creation
$form->addElement('SubmitButton', 'submit', array(
    'label' => <label value>,
    'dijitParams' => array('label' => <label value>),
));

In the view helper, specify a label parameter in the dijitParams argument:

$view->submitButton('submit', 'Label', array('label' => 'Label'));

If you specify both, your code will continue to work in the future as well.

People

Assignee:

Matthew Weier O'Phinney

Reporter:

Dannel Albert

Vote (0)

Watch (0)

Dates

Created:

18/Nov/08 11:36 AM

Updated:

21/Dec/08 5:51 AM

Resolved:

18/Nov/08 12:31 PM