ZF-5221: Zend_Http_CookieJar::_matchDomain() does not match domains with a dot prepended

Issue Type:
Bug
Created:
2008-12-11T18:16:25.000+0000
Last Updated:
2009-11-17T22:56:44.000+0000
Status:
Resolved
Fix version(s):
  • 1.9.0 (31/Jul/09)
Reporter:
Eric Yao (sourceboy)
Assignee:
Shahar Evron (shahar)
Tags:
  • Zend_Http_CookieJar
Related issues:
Attachments:

Description


// This is /1.php
// Suppose a cookie is set with:
setcookie('foo', 'bar', time() + 86400, '/', '.zend.com');
// With a dot prepended to zend.com, the cookie is also made available to all subdomains.


// This is /2.php
var_dump($_COOKIE);


// test.php
$request = new Zend_Http_Client();
$request->setCookieJar();

$request->setUri('http://zend.com/1.php');
$request->request();

$request->setUri('http://zend.com/2.php');
$response = $request->request();

echo $response->getBody();
// Output from the var_dump() in /2.php:
// array(0) {
// }

Comments

Posted by old of Satoru Yoshida (yoshida@zend.co.jp) on 2008-12-11T19:01:47.000+0000

Set component and auto reassign

Posted by Eric Yao (sourceboy) on 2008-12-11T20:37:29.000+0000

Zend_Http_Cookie::match() also doesn't match due to the same cause.

Posted by Eric Yao (sourceboy) on 2008-12-11T20:40:04.000+0000

These modifications seem to have fixed them:


Zend/Http/Cookie.php:

@@ -232,9 +232,16 @@
         if ($this->isSessionCookie() && ! $matchSessionCookies) return false;
 
         // Validate domain and path
-        // Domain is validated using tail match, while path is validated using head match
-        $domain_preg = preg_quote($this->getDomain(), "/");
-        if (! preg_match("/{$domain_preg}$/", $uri->getHost())) return false;
+        // Domain is validated using exact or tail match, while path is validated using head match
+        $domain = $this->getDomain();
+        $host = $uri->getHost();
+        $domain_preg = preg_quote($domain, '/');
+        if (
+            !preg_match("/{$domain_preg}$/", $host) &&
+            (($domain[0] === '.') && (strcasecmp(substr($domain, 1), $host) !== 0))
+        ) {
+            return false;
+        }
         $path_preg = preg_quote($this->getPath(), "/");
         if (! preg_match("/^{$path_preg}/", $uri->getPath())) return false;


Zend/Http/CookieJar.php:

@@ -297,8 +297,12 @@
         $ret = array();
 
         foreach (array_keys($this->cookies) as $cdom) {
-            $regex = "/" . preg_quote($cdom, "/") . "$/i";
-            if (preg_match($regex, $domain)) $ret[$cdom] = &$this->cookies[$cdom];
+                   if (($cdom[0] === '.') && (strcasecmp(substr($cdom, 1), $domain) === 0)) {
+                $ret[$cdom] = &$this->cookies[$cdom];
+                   } else {
+                $regex = "/" . preg_quote($cdom, "/") . "$/i";
+                if (preg_match($regex, $domain)) $ret[$cdom] = &$this->cookies[$cdom];
+            }
         }
 
         return $ret;

Posted by Shahar Evron (shahar) on 2009-07-25T14:11:21.000+0000

Congrats, fixed in rev. 17079 - thanks for reporting and for the patience :)

Posted by Satoru Yoshida (satoruyoshida) on 2009-11-17T22:56:44.000+0000

I set fix version. I find this at SVN r17118 in 1.9 branch.