Zend Framework

If there is a validation error, the Editor doesn't show its value again.

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.7.2
  • Fix Version/s: 1.7.9, 1.8.5, 1.9.7
  • Component/s: Zend_Dojo
  • Labels:
    None

Description

Here is the form:
$this->addElement(
'TextBox',
'Title',
array(
'label' => 'News Title:',
'required' => true,
'validators' => array(
array('NotEmpty', true),
),
)
);

$this->addElement(
'Editor',
'Content',
array(
'label' => 'News Content:',
'required' => true,
'height' => '150px',
'focusOnLoad' => true,
'validators' => array(
array('NotEmpty', true),
),
)
);

If there is a validation error, the Editor will set the value to "Array".

Because there are two elements named "Content", see the following html code:
<input id="Content" name="Content" value="" type="hidden" /><textarea id="Content[Editor]" name="Content[Editor]" type="text" height="150px" focusOnLoad="1" required="1" dojoType="dijit.Editor"></textarea>

And the solution is change the textarea element's id and name.

Open the Zend/Dojo/View/Helper/Editor.php:
change the following code:
protected function _normalizeEditorName($name)
{
if ('[]' == substr($name, -2)) { $name = substr($name, 0, strlen($name) - 2); $name .= '[Editor][]'; } else { $name .= '[Editor]'; }
return $name;
}

to:

protected function _normalizeEditorName($name)
{
if ('[]' == substr($name, -2)) { $name = substr($name, 0, strlen($name) - 2); $name .= '-Editor[]'; } else { $name .= '-Editor'; }
return $name;
}

Hope that helps.

Regard,
Justin

Issue Links

This issue is related to:
ZF-8127 Security issue in Zend_Dojo_View_Helper_Editor Major Resolved

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Wenlong Wu added a comment -

Another solution is:
Open the Zend/Dojo/View/Helper/Editor.php file:

change the following code:
$html = '<input' . $this->_htmlAttribs($hiddenAttribs) . $this->getClosingBracket()
. $this->textarea($textareaName, $value, $params, $attribs);

to:

$html = $this->textarea($textareaName, $value, $params, $attribs)
.'<input' . $this->_htmlAttribs($hiddenAttribs) . $this->getClosingBracket();

Show
Wenlong Wu added a comment - Another solution is: Open the Zend/Dojo/View/Helper/Editor.php file: change the following code: $html = '<input' . $this->_htmlAttribs($hiddenAttribs) . $this->getClosingBracket() . $this->textarea($textareaName, $value, $params, $attribs); to: $html = $this->textarea($textareaName, $value, $params, $attribs) .'<input' . $this->_htmlAttribs($hiddenAttribs) . $this->getClosingBracket();
Hide
Permalink
K added a comment -

Neither of the solutions work.

I am facing the same problem and am unable to capture the value type inside Editor.

If I hard code the value, like to 'something' below, then the server is able to capture the value correctly, on a valid post.
using the following code:
$form->editortab->getValue('content')

                                                  1. DOJO EDITOR ELEMENT #################################
                                                    $editorForm->addElement(
                                                    'Editor',
                                                    'content',
                                                    array(
                                                    'label' => 'Content',
                                                    'inheritWidth' => 'true',
                                                    'height' => '230px',
                                                    'width' => '200px',
                                                    'focusOnLoad' => true,
                                                    'required' => $required,
                                                    'value' => 'some',

)

Show
K added a comment - Neither of the solutions work. I am facing the same problem and am unable to capture the value type inside Editor. If I hard code the value, like to 'something' below, then the server is able to capture the value correctly, on a valid post. using the following code: $form->editortab->getValue('content')
                                                  1. DOJO EDITOR ELEMENT ################################# $editorForm->addElement( 'Editor', 'content', array( 'label' => 'Content', 'inheritWidth' => 'true', 'height' => '230px', 'width' => '200px', 'focusOnLoad' => true, 'required' => $required, 'value' => 'some',
)
Hide
Permalink
K added a comment -

Forgot to mention that when I hard-code, the value captured is only the text that I hard-coded (i.e. 'something') irrespective of what is actually typed on the UI

Show
K added a comment - Forgot to mention that when I hard-code, the value captured is only the text that I hard-coded (i.e. 'something') irrespective of what is actually typed on the UI
Hide
Permalink
K added a comment -

SOLVED

To make Zend Dojo Editor work do following to .../Zend/Dojo/View/Helper/Dijit.php

1- Inside _createGetParentFormFunction()
return elementNode.domNode;
instead of
return elementNode;

Show
K added a comment - SOLVED To make Zend Dojo Editor work do following to .../Zend/Dojo/View/Helper/Dijit.php 1- Inside _createGetParentFormFunction() return elementNode.domNode; instead of return elementNode;
Hide
Permalink
K added a comment -

However this solution only works for Firefox and not with the creepy Internet Explorer and the new kid called Google Crome

Show
K added a comment - However this solution only works for Firefox and not with the creepy Internet Explorer and the new kid called Google Crome
Hide
Permalink
Vladimir Razuvaev added a comment -

This issue appears because "textarea" tag is used as base for editor. Dojo doesn't recommend this for several reasons (including XSS vulnerability). It is much better to use "div" tag as a base for editor.

Here is a helper subclass, which replaces "textarea" tag to "div". Solution automatically fixes this bug and several other issues caused by same reason.

class MyEditor extends Zend_Dojo_View_Helper_Editor
{
    public function textarea($id, $value = null, array $params = array(), array $attribs = array())
    {
        // it is a trivial copy-paste of Zend_Dojo_View_Helper_Textarea::textarea method
        // with replaced "textarea" tag to "div"

        if (!array_key_exists('id', $attribs)) {
            $attribs['id']    = $id;
        }
        $attribs['name']  = $id;
        $attribs['type']  = $this->_elementType;

        $attribs = $this->_prepareDijit($attribs, $params, 'textarea');

        $html = '<div' . $this->_htmlAttribs($attribs) . '>'
              . $value
              . "</div>\n";

        return $html;
    }
}
Show
Vladimir Razuvaev added a comment - This issue appears because "textarea" tag is used as base for editor. Dojo doesn't recommend this for several reasons (including XSS vulnerability). It is much better to use "div" tag as a base for editor. Here is a helper subclass, which replaces "textarea" tag to "div". Solution automatically fixes this bug and several other issues caused by same reason. 
class MyEditor extends Zend_Dojo_View_Helper_Editor
{
    public function textarea($id, $value = null, array $params = array(), array $attribs = array())
    {
        // it is a trivial copy-paste of Zend_Dojo_View_Helper_Textarea::textarea method
        // with replaced "textarea" tag to "div"

        if (!array_key_exists('id', $attribs)) {
            $attribs['id']    = $id;
        }
        $attribs['name']  = $id;
        $attribs['type']  = $this->_elementType;

        $attribs = $this->_prepareDijit($attribs, $params, 'textarea');

        $html = '<div' . $this->_htmlAttribs($attribs) . '>'
              . $value
              . "</div>\n";

        return $html;
    }
}

People

Vote (2)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Zend Framework. Try JIRA - bug tracking software for your team.