Zend Framework

Zend_Date unit test alters value of static variable fix_dst. This biases later tests.

Details

  • Type: Unit Tests: Problem Unit Tests: Problem
  • Status: Resolved Resolved
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: 1.7.4
  • Fix Version/s: 1.8.0
  • Component/s: Zend_Date
  • Labels:
    None

Description

Zend/DateTest.php, function testAddMonth, line 4180:

Zend_Date::setOptions(array('fix_dst' => false));

The above code alters a static variable such that it differs from the default. This influences the outcome of later tests.

This is the cause of the ZF-5745.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Georg-Hendrik Haan added a comment -

This issue has been stale for a week, while other issues are being solved.

Was I wrong to label this as a blocker?
Is it not the case that 20% of Zend_Date unit test results are corrupt due to this?
Can someone please confirm this as a problem?

Show
Georg-Hendrik Haan added a comment - This issue has been stale for a week, while other issues are being solved. Was I wrong to label this as a blocker? Is it not the case that 20% of Zend_Date unit test results are corrupt due to this? Can someone please confirm this as a problem?
Hide
Permalink
Thomas Weidner added a comment -

Please be patient.
We can not solve all 1000 bugs and feature requests in one week.

Show
Thomas Weidner added a comment - Please be patient. We can not solve all 1000 bugs and feature requests in one week.
Hide
Permalink
Georg-Hendrik Haan added a comment -

Please note that I'm not asking you to solve all 1000 bugs and feature requests in one week.

My comment was a plea to follow the priority system.

Issue ZF-5765 causes data loss and other irreversible damage for Zend Framework users.
The issue is labeled as critical, is clearly explained and is easy to confirm or disprove.
Still, low priority issues filed after this one are being resolved while 5765 seemed to be ignored.

I could not find a logical explanation for this other than that somehow this issue does not show in reports or similar.
Now that you've acknowledged, I can rest assured that this will be fixed in an appropriate time frame.

Kind regards,

Show
Georg-Hendrik Haan added a comment - Please note that I'm not asking you to solve all 1000 bugs and feature requests in one week. My comment was a plea to follow the priority system. Issue ZF-5765 causes data loss and other irreversible damage for Zend Framework users. The issue is labeled as critical, is clearly explained and is easy to confirm or disprove. Still, low priority issues filed after this one are being resolved while 5765 seemed to be ignored. I could not find a logical explanation for this other than that somehow this issue does not show in reports or similar. Now that you've acknowledged, I can rest assured that this will be fixed in an appropriate time frame. Kind regards,
Hide
Permalink
Thomas Weidner added a comment -

I don't know from where you get your knowledge but I have not solved any other issue except those which are no issue at all.

Only because I am working in the background does not mean that there is nothing done at all.
A solution, decission or negotation of this issue is only done when all cases have been prooved.

So please be patient. That is all I've asked for.

Show
Thomas Weidner added a comment - I don't know from where you get your knowledge but I have not solved any other issue except those which are no issue at all. Only because I am working in the background does not mean that there is nothing done at all. A solution, decission or negotation of this issue is only done when all cases have been prooved. So please be patient. That is all I've asked for.
Hide
Permalink
Thomas Weidner added a comment -

Unittests changed. Testbed passes without problems.

Show
Thomas Weidner added a comment - Unittests changed. Testbed passes without problems.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Zend Framework. Try JIRA - bug tracking software for your team.