ZF-5805: Make protected methods of Zend_Controller_Action public

Issue Type:
Improvement
Created:
2009-02-16T16:41:41.000+0000
Last Updated:
2012-01-03T22:06:20.000+0000
Status:
Resolved
Fix version(s):
  • 1.12.0 (27/Aug/12)
Reporter:
Matthew Weier O'Phinney (matthew)
Assignee:
Matthew Weier O'Phinney (matthew)
Tags:
  • Zend_Controller
Related issues:
Attachments:

Description

Currently, Zend_Controller_Action has a number of protected "helper" methods. There is no good reason for these to be protected, and it actually makes it difficult for action helpers to have introspection and access to valuable processes in Zend_Controller_Action. These methods include:

  • _getParam()
  • _setParam()
  • _hasParam()
  • _getAllParams()
  • _forward()
  • _redirect

Public methods should be provided, and the protected methods marked as deprecated.; the protected methods will proxy to the public methods in the interim.

Comments

Posted by julien PAULI (doctorrock83) on 2009-02-20T02:41:44.000+0000

When will we be given from the PHP devs a 'package' visibility ? ... :-(

Posted by Diego Tremper (diegotremper) on 2009-04-07T01:12:48.000+0000

Patch for this issue.

Posted by Adam Lundrigan (adamlundrigan) on 2011-12-06T12:11:19.000+0000

This is marked as "Next Minor Release". Will this, then, be addressed in v1.12?

Posted by Matthew Weier O'Phinney (matthew) on 2012-01-03T22:06:08.000+0000

Yes -- 1.12, as it marks existing methods deprecated and adds new methods. I've applied the patch to trunk at this time, and it will be incorporated in 1.12.