ZF-5932: $event->when looks for an array, not a string

Issue Type:
Docs: Problem
Created:
2009-03-03T14:15:40.000+0000
Last Updated:
2009-03-04T17:29:15.000+0000
Status:
Resolved
Fix version(s):
  • 1.7.7 (16/Mar/09)
Reporter:
Zachary Burnham (zburnham)
Assignee:
Trevor Johns (tjohns)
Tags:
  • Zend_Gdata
Related issues:
Attachments:

Description

The setWhen method of Zend_Gdata_Kind_EventEntry expects an array as its argument. The document is inconsistent between examples in 22.5.4.1 and 22.5.4.2; of the three examples given, two treat as an array and one as a single instance. Patch:

Index: Zend_Gdata_Calendar.xml

--- Zend_Gdata_Calendar.xml (revision 14213) +++ Zend_Gdata_Calendar.xml (working copy) @@ -582,7 +582,7 @@ $when->endTime="2007-12-05T15:00:00:00-08:00";

// Apply the when property to an event -$event->when = $when; +$event->when = array($when); ]]>

Comments

Posted by Trevor Johns (tjohns) on 2009-03-03T14:45:17.000+0000

Hi Zachary, many thanks for the patch, it's much appreciated!

However, before I can apply it, you'll need to have a signed Contributor License Agreement (CLA) on file with the Zend Framework project. Instructions on doing this and an FAQ are here:

http://framework.zend.com/community/contribute

Would you be okay with this? Please let me know if you have any questions.

Posted by Zachary Burnham (zburnham) on 2009-03-03T16:11:03.000+0000

I have no problem with the Agreement. I'll fax it back to you shortly.

Posted by Trevor Johns (tjohns) on 2009-03-03T16:28:31.000+0000

Great!

Please follow up on this issue to let me know once the CLA has been received by Zend. I don't work there, so I won't get notified otherwise. :)

Posted by Zachary Burnham (zburnham) on 2009-03-04T08:31:43.000+0000

I faxed the CLA to Zend last night. I don't know if there's other confirmation to be obtained, and I haven't heard anything from them.

Posted by Zachary Burnham (zburnham) on 2009-03-04T17:07:07.000+0000

The CLA has been received and processed.

Posted by Trevor Johns (tjohns) on 2009-03-04T17:20:30.000+0000

I had to rebuild the patch, because Jira treated spaces and such as formatting, causing me to get the following error:

$ patch -p0 < ~/Desktop/zf-5932.patch 
patching file Zend_Gdata_Calendar.xml
patch: **** malformed patch at line 6: $when->endTime="2007-12-05T15:00:00:00-08:00"

I've attached the re-built patch that fixes this.

Posted by Trevor Johns (tjohns) on 2009-03-04T17:29:15.000+0000

Commited to trunk as r14225. Merged to release-1.7 as r14226. Marking as fixed for next mini release.

commit 48d6b58aea687124fe0fca1e4d7abf5023842a0b
Author: tjohns 
Date:   Thu Mar 5 01:25:31 2009 +0000

    ZF-5932: Fix problem in Zend_Gdata_Calendar documentation: $event->when looks
    for an array, not a string.
    
    Patch by: zburnham
    
    git-svn-id: http://framework.zend.com/svn/framework/… 44c647ce-9c0f-0

commit a1898cabce1a621da61e7933985a2fd5dcbcae7b
Author: tjohns 
Date:   Thu Mar 5 01:27:36 2009 +0000

    Merge r14225 from trunk to release-1.7.
    
    ZF-5932: Fix problem in Zend_Gdata_Calendar documentation: $event->when looks
    for an array, not a string.
    
    Patch by: zburnham
    
    git-svn-id: http://framework.zend.com/svn/framework/…

Thanks again for the patch, Zachary!