Issues

ZF-5932: $event->when looks for an array, not a string

Description

The setWhen method of Zend_Gdata_Kind_EventEntry expects an array as its argument. The document is inconsistent between examples in 22.5.4.1 and 22.5.4.2; of the three examples given, two treat as an array and one as a single instance. Patch:

Index: Zend_Gdata_Calendar.xml

--- Zend_Gdata_Calendar.xml (revision 14213) +++ Zend_Gdata_Calendar.xml (working copy) @@ -582,7 +582,7 @@ $when->endTime="2007-12-05T15:00:00:00-08:00";

// Apply the when property to an event -$event->when = $when; +$event->when = array($when); ]]>

Comments

Hi Zachary, many thanks for the patch, it's much appreciated!

However, before I can apply it, you'll need to have a signed Contributor License Agreement (CLA) on file with the Zend Framework project. Instructions on doing this and an FAQ are here:

http://framework.zend.com/community/contribute

Would you be okay with this? Please let me know if you have any questions.

I have no problem with the Agreement. I'll fax it back to you shortly.

Great!

Please follow up on this issue to let me know once the CLA has been received by Zend. I don't work there, so I won't get notified otherwise. :)

I faxed the CLA to Zend last night. I don't know if there's other confirmation to be obtained, and I haven't heard anything from them.

The CLA has been received and processed.

I had to rebuild the patch, because Jira treated spaces and such as formatting, causing me to get the following error:

$ patch -p0 < ~/Desktop/zf-5932.patch 
patching file Zend_Gdata_Calendar.xml
patch: **** malformed patch at line 6: $when->endTime="2007-12-05T15:00:00:00-08:00"

I've attached the re-built patch that fixes this.

Commited to trunk as r14225. Merged to release-1.7 as r14226. Marking as fixed for next mini release.

commit 48d6b58aea687124fe0fca1e4d7abf5023842a0b
Author: tjohns 
Date:   Thu Mar 5 01:25:31 2009 +0000

    ZF-5932: Fix problem in Zend_Gdata_Calendar documentation: $event->when looks
    for an array, not a string.
    
    Patch by: zburnham
    
    git-svn-id: http://framework.zend.com/svn/framework/… 44c647ce-9c0f-0

commit a1898cabce1a621da61e7933985a2fd5dcbcae7b
Author: tjohns 
Date:   Thu Mar 5 01:27:36 2009 +0000

    Merge r14225 from trunk to release-1.7.
    
    ZF-5932: Fix problem in Zend_Gdata_Calendar documentation: $event->when looks
    for an array, not a string.
    
    Patch by: zburnham
    
    git-svn-id: http://framework.zend.com/svn/framework/… 

Thanks again for the patch, Zachary!