Zend Framework

Zend_Test generates vague failure messages

Details

  • Type: Improvement Improvement
  • Status: Resolved Resolved
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.7.0, 1.7.1, 1.7.2, 1.7.3, 1.7.4, 1.7.5, 1.7.6
  • Fix Version/s: 1.9.3
  • Component/s: Zend_Test_PHPUnit
  • Labels:
    None

Description

There was 1 failure:

1) testExpiredPasswordForcesPasswordChange(Default_AuthControllerTest)
Failed asserting last controller used was "auth"

This message could be a lot more explict. e.g. Failed asserting last controller used ("index") was "auth"

The same goes for the redirect failures as well. PHPUnit itself always gives very explicit failure messages - "Failed asserting 0 equals 1".

Activity

Hide
Till Klampaeckel added a comment -

Matthew,

I could improve these easily. Should I add a patch first here

Till

Show
Till Klampaeckel added a comment - Matthew, I could improve these easily. Should I add a patch first here Till
Hide
Matthew Weier O'Phinney added a comment -

Till – yes, please do. Make sure the patch includes changes to the unit tests so I don't have to hunt those down.

Show
Matthew Weier O'Phinney added a comment - Till – yes, please do. Make sure the patch includes changes to the unit tests so I don't have to hunt those down.
Hide
Benjamin Eberlei added a comment -

Fixed and merged into 1.9 release branch.

Show
Benjamin Eberlei added a comment - Fixed and merged into 1.9 release branch.

People

Vote (1)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: