ZF-6013: Zend_Test generates vague failure messages

Issue Type:
Improvement
Created:
2009-03-12T12:06:41.000+0000
Last Updated:
2009-09-18T00:55:26.000+0000
Status:
Resolved
Fix version(s):
  • 1.9.3 (22/Sep/09)
Reporter:
David Abdemoulaie (hobodave)
Assignee:
Matthew Weier O'Phinney (matthew)
Tags:
  • Zend_Test_PHPUnit
Related issues:
Attachments:

Description

There was 1 failure:

1) testExpiredPasswordForcesPasswordChange(Default_AuthControllerTest) Failed asserting last controller used was "auth"

This message could be a lot more explict. e.g. Failed asserting last controller used ("index") was "auth"

The same goes for the redirect failures as well. PHPUnit itself always gives very explicit failure messages - "Failed asserting 0 equals 1".

Comments

Posted by Till Klampaeckel (till) on 2009-03-30T11:30:15.000+0000

Matthew,

I could improve these easily. Should I add a patch first here

Till

Posted by Matthew Weier O'Phinney (matthew) on 2009-03-30T11:59:11.000+0000

Till -- yes, please do. Make sure the patch includes changes to the unit tests so I don't have to hunt those down.

Posted by Benjamin Eberlei (beberlei) on 2009-09-18T00:55:22.000+0000

Fixed and merged into 1.9 release branch.