Details
-
Type:
Bug
-
Status:
Resolved
-
Priority:
Trivial
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 1.11.0
-
Component/s: Zend_Controller
-
Labels:None
Description
Zend_Controller_Router_Route_Static::match
--------------------------------------------------------------------------
public function match($path)
{
if ($this->isPartial()) {
if (substr($path, 0, strlen($this->_route)) === $this->_route) {
$this->setMatchedPath($this->_route);
return $this->_defaults;
}
} else {
---------------------------------------------------------------------------
When $this->_route is empty, construction substr($path, 0, strlen($this->_route)) return "bool(false)" and condition If is not fullfilled
Issue Links
| This issue is duplicated by: | ||||
| ZF-7848 | Empty static route (empty string) will NEVER match (sample from docs, Route_Hostname, Route_Static) |
|
|
|
Activity
When default router disabled and path '/' should point to the non default IndexController::indexAction
following occurs:
I add route:
$router->addRoute(
'index',
new Zend_Controller_Router_Route_Static('/',
array('controller' => 'user',
'action' => 'info'))
);
Zend_Controller_Router_Route_Static::_construct do:
---------------
public function __construct($route, $defaults = array())
---------------
Afther that we have empty string in $this->_route
Then in match
--------------
if (substr($path, 0, strlen($this->_route)) === $this->_route) {
--------------
It's wrong condition, mistake in "==="
Other example illustrate the problem:
<?php
$path = '/';
//
$test = trim($path, '/');
var_dump($test);
//
$result = substr($test, 0, strlen($test));
var_dump($result);
/**
- Wrong way
*/
if ($result === $test) { echo "Work"; } else { echo "Don't work"; }
/**
* Right way
*/
if ($result == $test) { echo "Work"; }
} else { echo "Don't work"; }
PS: Sorry for my enlish, code speaks better 
- Wrong way */ if ($result === $test) { echo "Work"; } else { echo "Don't work"; } /** * Right way */ if ($result == $test) { echo "Work"; } } else { echo "Don't work"; }
Can you provide an example of when this is a problem, exactly? I'm having trouble finding a case where this would not actually be the correct and/or expected behavior.