Zend Framework

Tailing period is incorrectly classified as invalid

Details

Description

Zend_Uri currently considers http://www.bob.com. invalid when in fact this is a valid uri.

Issue Links

This issue is dependecy of:
ZF-11451 Zend Validate fails to validate emails with dot at the end Major Resolved

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jacob Kiers added a comment -

According to RFC 3986 (Uniform Resource Identifier (URI): Generic Syntax), section 3.2.2 a trailing dot is perfectly valid.

A fix is created, together with a unittest. I will upload the patch as soon as my CLA is processed.

Show
Jacob Kiers added a comment - According to RFC 3986 (Uniform Resource Identifier (URI): Generic Syntax), section 3.2.2 a trailing dot is perfectly valid. A fix is created, together with a unittest. I will upload the patch as soon as my CLA is processed.
Hide
Permalink
Jacob Kiers added a comment -

My CLA is processed and the patch is attached.

Show
Jacob Kiers added a comment - My CLA is processed and the patch is attached.
Hide
Permalink
Marc Hodgins added a comment -

Thank you for the report and thanks for the patch Jacob. Added a unit test and applied to trunk in r23487, merged to 1.11 release branch in r23488.

Show
Marc Hodgins added a comment - Thank you for the report and thanks for the patch Jacob. Added a unit test and applied to trunk in r23487, merged to 1.11 release branch in r23488.
Hide
Permalink
Jacob Kiers added a comment -

Mark, I did have a test, but it seams it wasn't in the patch. I'll doublecheck next time. Thanks for creating one!

Show
Jacob Kiers added a comment - Mark, I did have a test, but it seams it wasn't in the patch. I'll doublecheck next time. Thanks for creating one!
Hide
Permalink
Thomas Weidner added a comment -

Note that your fix does not work with some settings
A fixed implementation can be found in pull request 229 for ZF2

Show
Thomas Weidner added a comment - Note that your fix does not work with some settings A fixed implementation can be found in pull request 229 for ZF2
Hide
Permalink
Jacob Kiers added a comment -

Hi Thomas, thanks for the fix. I backported your changes and attached a patch.

Show
Jacob Kiers added a comment - Hi Thomas, thanks for the fix. I backported your changes and attached a patch.
Hide
Permalink
Jacob Kiers added a comment -

Backported patch from ZF2 pull request 229 (https://github.com/zendframework/zf2/pull/229)

Show
Jacob Kiers added a comment - Backported patch from ZF2 pull request 229 (https://github.com/zendframework/zf2/pull/229)
Hide
Permalink
Jacob Kiers added a comment -

Re-opening issue to make it more likely someone with commit rights checks and applies the new patch.

Show
Jacob Kiers added a comment - Re-opening issue to make it more likely someone with commit rights checks and applies the new patch.
Hide
Permalink
Adam Lundrigan added a comment -

Backported fix from ZF2:
https://github.com/thomasweidner/zf2/commit/7882b336830e2f67e48bede18957c47ba1a19be9

Committed to trunk in r24306
Merged to release-1.11 in r24307

Show
Adam Lundrigan added a comment - Backported fix from ZF2: https://github.com/thomasweidner/zf2/commit/7882b336830e2f67e48bede18957c47ba1a19be9 Committed to trunk in r24306 Merged to release-1.11 in r24307
Hide
Permalink
Thomas Weidner added a comment -

Fixed in ZF2 with GH-279

Show
Thomas Weidner added a comment - Fixed in ZF2 with GH-279

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Zend Framework. Try JIRA - bug tracking software for your team.