Zend Framework

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Won't Fix
• Affects Version/s: Next Major Release
• Fix Version/s: 1.8.2
• Component/s: Zend_File_Transfer
• Labels:

  None

Zend_File_Transfer_Adapter_Abstract does not properly implement adding validators with multiple parameters in their constructors.

line 335 of 1.8 beta 1:

$name      = $this->getPluginLoader(self::VALIDATE)->load($validator);
$validator = new $name($options);
if (is_array($options) && isset($options['messages'])) {
    if (is_array($options['messages'])) {
        $validator->setMessages($options['messages']);
    } elseif (is_string($options['messages'])) {
        $validator->setMessage($options['messages']);
    }

    unset($options['messages']);
}

this should be more similar to protected function _loadValidator(array $validator) in Zend_Form_Element:

if (empty($options)) {
    $validator = new $name;
} else {
    $messages = false;
    if (isset($options['messages'])) {
        $messages = $options['messages'];
        unset($options['messages']);
    }

    $r = new ReflectionClass($name);
    if ($r->hasMethod('__construct')) {
        $validator = $r->newInstanceArgs((array) $options);
    } else {
        $validator = $r->newInstance();
    }

    if ($messages) {
        if (is_array($messages)) {
            $validator->setMessages($messages);
        } elseif (is_string($messages)) {
            $validator->setMessage($messages);
        }
    }
}

• Assignee:

  Thomas Weidner

  Reporter:

  Michael

• Created:

  24/Apr/09 9:54 AM

  Updated:

  16/May/09 9:49 AM

  Resolved:

  16/May/09 9:49 AM