Zend Framework

Zend_Application_Resource_Frontcontroller overwrites multiple controller directories

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: 1.8.0
  • Fix Version/s: 1.8.1
  • Component/s: Zend_Application
  • Labels:
    None

Description

This is in reference to ticket ZF-6244, which I believe was misunderstood. Because Zend_Controller_Front::setControllerDirectory() clears any existing controller directories every time that it is invoked, using the foreach loop in Zend_Application_Resource_Frontcontroller:54, only the last directory in the array of controller directories will remain set, regardless of the uniqueness of the module => directory pairs you pass in. The solution that I see for this issue is to remove the foreach loop in the front controller resource, and just pass in the array (setControllerDirectory() accepts an array by default). I am using revision 15243 (1.8.0dev)

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Ken Stanley added a comment -

This is a patch removes the condition check for if $value is a string and just passes $value to Zend_Controller_Front::setControllerDirectory().

Show
Ken Stanley added a comment - This is a patch removes the condition check for if $value is a string and just passes $value to Zend_Controller_Front::setControllerDirectory().
Hide
Permalink
Matthew Weier O'Phinney added a comment -

What's odd is that setControllerDirectory() is not written such that it should overwrite – and yet I just verified that it does.

As a workaround until this is fixed, I'd recommend keeping your modules under a common directory, and using the moduleDirectory configuration key instead of controllerDirectory.

Show
Matthew Weier O'Phinney added a comment - What's odd is that setControllerDirectory() is not written such that it should overwrite – and yet I just verified that it does. As a workaround until this is fixed, I'd recommend keeping your modules under a common directory, and using the moduleDirectory configuration key instead of controllerDirectory.
Hide
Permalink
Ken Stanley added a comment -

I was mistaken when I first made the report. It's not in Zend_Controller_Front::setControllerDirectory(). It's actually in Zend_Controller_Dispatcher_Standard::setControllerDirectory(). It's the first line of the method, and it assigns an empty array to $this->_controllerDirectory. Apologies for the confusion.

Show
Ken Stanley added a comment - I was mistaken when I first made the report. It's not in Zend_Controller_Front::setControllerDirectory(). It's actually in Zend_Controller_Dispatcher_Standard::setControllerDirectory(). It's the first line of the method, and it assigns an empty array to $this->_controllerDirectory. Apologies for the confusion.
Hide
Permalink
Mark Lindeman added a comment -

IMHO this is a very high priority bug: for existing ZF based applications with multiple modules it's nearly impossible to upgrade to the 1.8 release.

To make the problem even more clear: using the new Zend_Application, if you create an .ini file with these lines:

[production]
includePaths.library = APPLICATION_PATH "/../library"
bootstrap.path = APPLICATION_PATH "/Bootstrap.php"
bootstrap.class = "Bootstrap"
resources.frontController.controllerDirectory.default = APPLICATION_PATH "/default/controllers"
resources.frontController.controllerDirectory.module1 = APPLICATION_PATH "/module1/controllers"

than the Application_Resource_Frontcontroller invokes the Frontcontroller's setControllerDirectory which in turn invokes the Dispatcher method setControllerDirectory which resets the internal _controllerDirectory array each time it's called.

The solution is really simple: Application_Resource_Frontcontroller should use addControllerDirectory in stead of setControllerDirectory. For your convenience I've attached a patch file.

Show
Mark Lindeman added a comment - IMHO this is a very high priority bug: for existing ZF based applications with multiple modules it's nearly impossible to upgrade to the 1.8 release. To make the problem even more clear: using the new Zend_Application, if you create an .ini file with these lines: [production] includePaths.library = APPLICATION_PATH "/../library" bootstrap.path = APPLICATION_PATH "/Bootstrap.php" bootstrap.class = "Bootstrap" resources.frontController.controllerDirectory.default = APPLICATION_PATH "/default/controllers" resources.frontController.controllerDirectory.module1 = APPLICATION_PATH "/module1/controllers" than the Application_Resource_Frontcontroller invokes the Frontcontroller's setControllerDirectory which in turn invokes the Dispatcher method setControllerDirectory which resets the internal _controllerDirectory array each time it's called. The solution is really simple: Application_Resource_Frontcontroller should use addControllerDirectory in stead of setControllerDirectory. For your convenience I've attached a patch file.
Hide
Permalink
Matthew Weier O'Phinney added a comment -

Fixed in trunk and 1.8 release branch.

Show
Matthew Weier O'Phinney added a comment - Fixed in trunk and 1.8 release branch.

People

Vote (1)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Zend Framework. Try JIRA - bug tracking software for your team.