Zend Framework

Support for locale-awareness for all number validators.

Details

  • Type: Improvement Improvement
  • Status: In Progress In Progress
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 1.8.0
  • Fix Version/s: None
  • Component/s: Zend_Validate
  • Labels:
    None

Description

Now we get this confusing situation while Float validator is locale-aware, but Between is not, so we cannot mix them when locale is used for Float validator.
Some generic solution should be provided, like adding locale-awareness in Zend_Validate_Abstract and using it inside validators for numbers.

Issue Links

This issue is duplicated by:
ZF-11276 Zend_Validate_Between Major Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Thomas Weidner added a comment -

Please be patient:
Only because I began to add locale awareness to some filters it does not mean that these validators don't work.

Each addition has to go through a review process and this takes time.

According to "number validator inside Abstract class"...
Definetly no: Abstract should not add validator specific rules or methods.

A validator for StringLength or a Regex validator don't have the need to use localizing methods.

And float and boolean have different needs of localization.
This won't work.

Validators have eighter to be independent from each other, OR the extend each other. So when a Between validator needs number validation it should extend Zend_Validate_Number or a related validator.

Show
Thomas Weidner added a comment - Please be patient: Only because I began to add locale awareness to some filters it does not mean that these validators don't work. Each addition has to go through a review process and this takes time. According to "number validator inside Abstract class"... Definetly no: Abstract should not add validator specific rules or methods. A validator for StringLength or a Regex validator don't have the need to use localizing methods. And float and boolean have different needs of localization. This won't work. Validators have eighter to be independent from each other, OR the extend each other. So when a Between validator needs number validation it should extend Zend_Validate_Number or a related validator.
Hide
Permalink
Thomas Weidner added a comment -

@dev-team:
The following validators need localization to have a unique API:

  • Zend_Validate_Between
  • Zend_Validate_GreaterThan
  • Zend_Validate_LessThan

The proposed way is to have each validator independently from others even if this would mean to duplicate existing code. The API of all 5 validators (Int and Float are already localized) should be completly the same.

The API itself is

  • setLocale
  • getLocale
  • Setting the locale at initiation
  • No locale set -> use non-localized behaviour
Show
Thomas Weidner added a comment - @dev-team: The following validators need localization to have a unique API:
  • Zend_Validate_Between
  • Zend_Validate_GreaterThan
  • Zend_Validate_LessThan
The proposed way is to have each validator independently from others even if this would mean to duplicate existing code. The API of all 5 validators (Int and Float are already localized) should be completly the same. The API itself is
  • setLocale
  • getLocale
  • Setting the locale at initiation
  • No locale set -> use non-localized behaviour

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Zend Framework. Try JIRA - bug tracking software for your team.