ZF-6614: Zend_Feed_Rss pubDate should be localtime rather than gmdate('r')

Issue Type:
Bug
Created:
2009-05-11T19:02:22.000+0000
Last Updated:
2009-09-18T11:32:58.000+0000
Status:
Resolved
Fix version(s):
  • 1.9.3 (22/Sep/09)
Reporter:
twk (twk)
Assignee:
Pádraic Brady (padraic)
Tags:
  • Zend_Feed
Related issues:
Attachments:

Description

zend/feed/rss.php line 425 and other places makes pubDate like the following. $pubdate = $this->_element->createElement('pubDate', gmdate('r', $pubdate)); This always generates timzone +0000 like "Tue, 12 May 2009 02:01:07 +0000".

I think the feed should generate in local timezone.

Something like $pubdate = new Zend_Date($pubdate); $pubdate = $this->_element->createElement('pubDate', $pubdate->get(Zend_Date::RSS)); would generate in local time zone. (though this adds dependency to Zend_Date)

I do not know about the atom class, but the same issue may exist.

Comments

Posted by twk (twk) on 2009-05-11T19:08:40.000+0000

atom uses date(DATE_ATOM) and it shows in the local timezone. so you may just use date(DATE_RSS) for rss?

Posted by Pádraic Brady (padraic) on 2009-09-18T11:32:55.000+0000

Fixed in r18265