ZF-6765: Zend_Filter_Input::_validateRule() iterates through provided fields when it's not necessary

Issue Type:
Improvement
Created:
2009-05-21T04:58:19.000+0000
Last Updated:
2009-05-22T06:12:45.000+0000
Status:
Resolved
Fix version(s):
  • 1.8.2 (27/May/09)
Reporter:
Alexander Veremyev (alexander)
Assignee:
Alexander Veremyev (alexander)
Tags:
  • Zend_Filter_Input
Related issues:
Attachments:

Description

Zend_Filter_Input::_validateRule() has the following code:


/**
 * Evaluate the inputs against the validator chain.
 */
if (count((array) $validatorRule[self::FIELDS]) > 1) {
    ....
} else {
    $failed = false;
    foreach ($data as $fieldKey => $field) {
        ....
    }
    ....
}

But $data cardinality is always less than (array) $validatorRule[self::FIELDS] cardinality since $data elements are collected by iterating through it.

It's not a bug, but it reduces code readability ($data is always one element array).

Comments

Posted by Alexander Veremyev (alexander) on 2009-05-22T06:12:45.000+0000

Fixed