Zend Framework

Incorrect behaviour in Zend_Form_Decorator_Label

Details

  • Type: Sub-task Sub-task
  • Status: In Progress In Progress
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: Zend_Form
  • Labels:
    None

Description

The docs for this decorator state:
"You may optionally specify a 'tag' option; if provided, it wraps the label in that block-level tag. If the 'tag' option is present, and no label present, the tag is rendered with no content. You can specify the class to use with the tag with the 'class' option or by calling setClass(). "

However, passing the 'class' option or calling setClass actually sets the class for the label, not the tag which wraps it, severely limiting the utility of the tag option.

Suggested fix: add a 'tagClass' option.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Mark added a comment - - edited

Fix: added tagOptions option to Zend_Form_Decorator_Label. These options are then passed to the HtmlTag decorator which wraps the label tag. These options do not overwrite the tag or id options specified in Zend_Form_Decorator_Label::render

Also attached is a test for this change.

This is my first patch / test so any feedback welcome.

Show
Mark added a comment - - edited Fix: added tagOptions option to Zend_Form_Decorator_Label. These options are then passed to the HtmlTag decorator which wraps the label tag. These options do not overwrite the tag or id options specified in Zend_Form_Decorator_Label::render Also attached is a test for this change. This is my first patch / test so any feedback welcome.
Hide
Permalink
Peter Sharp added a comment -

I wonder if the existing options should be updated to reflect the tagOptions functionality instead of actually adding tagOptions.

When specifying the label, you can set all of the class / id / etc attributes as you wish. I don't know if there is really a need for two interfaces to a single set of attributes.

Just a thought.

Show
Peter Sharp added a comment - I wonder if the existing options should be updated to reflect the tagOptions functionality instead of actually adding tagOptions. When specifying the label, you can set all of the class / id / etc attributes as you wish. I don't know if there is really a need for two interfaces to a single set of attributes. Just a thought.
Hide
Permalink
Mark added a comment -

You can set the attributes (class, etc.) for the label in the existing options; what you cannot currently do is set the attributes for the optional tag which wraps the label. Further, the docs state that you can set the tag class using setClass() - this is not true.

So you can currently create markup like:
<div><label class=something otherAttr=somethingElse>My Label</label></div>

What the docs state you can do, and my patch implements, is to create markup like
<div class=myTagClass><label class=something otherAttr=somethingElse>My Label</label></div>

And my patch also allows you to have arbitrary attributes to the tag like
<div class=myTagClass myOtherAttr=someOtherAttr><label class=something otherAttr=somethingElse>My Label</label></div>

Cheers,
Mark

Show
Mark added a comment - You can set the attributes (class, etc.) for the label in the existing options; what you cannot currently do is set the attributes for the optional tag which wraps the label. Further, the docs state that you can set the tag class using setClass() - this is not true. So you can currently create markup like: <div><label class=something otherAttr=somethingElse>My Label</label></div> What the docs state you can do, and my patch implements, is to create markup like <div class=myTagClass><label class=something otherAttr=somethingElse>My Label</label></div> And my patch also allows you to have arbitrary attributes to the tag like <div class=myTagClass myOtherAttr=someOtherAttr><label class=something otherAttr=somethingElse>My Label</label></div> Cheers, Mark

People

Vote (1)
Watch (4)

Dates

  • Created:
    Updated:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Zend Framework. Try JIRA - bug tracking software for your team.