Zend Framework

Zend_Form_Element_Hash does not set a value when renderViewHelper() is called

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.8.4
  • Fix Version/s: 1.9.6
  • Component/s: Zend_Form
  • Labels:
    None

Description

When you have a Zend_Form_Element_Hash element in your form, and you try to render the element not via the regular render() method, but via renderViewHelper(), then the element is rendered without the token set in the value.

The regular render() method is normally inherrited from Zend_Form_Element, but it is redefined so that the method initCsrfToken() is called to initialize the token in the session, before the rendering takes place.

Perhaps the renderViewHelper() method should be explicitly defined in Zend_Form_Element_Hash, so initCsrfToken() can also be invoked before rendering the ViewHelper.

Attachments

  1. File
    Element.diff
    19/Nov/09 10:18 PM
    1 kB
    Mon Zafra
  2. File
    HashTest.diff
    19/Nov/09 10:18 PM
    0.7 kB
    Mon Zafra

Issue Links

This issue is related to:
ZF-8419 _isPartialRendering in Zend_Form_Element can break Zend_Form_Element_File::render() Major Resolved

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jelle-Jan van Veelen added a comment -

I encountered this one for the second time. Would it be possible to have some kind of initialisation / preparation method that is called before the element is rendered?

As Tom points out, the initCsrfToken() method is only called from within the render() method.

Show
Jelle-Jan van Veelen added a comment - I encountered this one for the second time. Would it be possible to have some kind of initialisation / preparation method that is called before the element is rendered? As Tom points out, the initCsrfToken() method is only called from within the render() method.
Hide
Permalink
Mon Zafra added a comment - - edited

Here is my proposed fix. I made the magic render method call the element's render() method, but the parent::render() call is skipped by checking a flag which is set before and after the render() call inside the magic method. Please review.

Show
Mon Zafra added a comment - - edited Here is my proposed fix. I made the magic render method call the element's render() method, but the parent::render() call is skipped by checking a flag which is set before and after the render() call inside the magic method. Please review.
Hide
Permalink
Mon Zafra added a comment -

Sorry, was only checking out the resolve page, accidentally submitted

Show
Mon Zafra added a comment - Sorry, was only checking out the resolve page, accidentally submitted
Hide
Permalink
Mon Zafra added a comment -

Changed diffs to svn-generated diffs instead of Netbeans.

Show
Mon Zafra added a comment - Changed diffs to svn-generated diffs instead of Netbeans.
Hide
Permalink
Matthew Weier O'Phinney added a comment -

Patches applied to trunk and 1.9 release branch – thanks!

Show
Matthew Weier O'Phinney added a comment - Patches applied to trunk and 1.9 release branch – thanks!
Hide
Permalink
Jason Hutchens added a comment -

The introduction of _isPartialRendering causes Zend_Form_Element_File::render() to be called from Zend_Form_Element_File::renderViewHelper(), which raises an exception when the form element has no decorators. This breaks the file upload form on our site. I've logged this as ZF-8419.

A better solution would be to implement Zend_Form_Element::partialRender(), with an empty default implementation, and for Zend_Form_Element_Hash to implement this to fix ZF-7404.

Show
Jason Hutchens added a comment - The introduction of _isPartialRendering causes Zend_Form_Element_File::render() to be called from Zend_Form_Element_File::renderViewHelper(), which raises an exception when the form element has no decorators. This breaks the file upload form on our site. I've logged this as ZF-8419. A better solution would be to implement Zend_Form_Element::partialRender(), with an empty default implementation, and for Zend_Form_Element_Hash to implement this to fix ZF-7404.

People

Vote (0)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Zend Framework. Try JIRA - bug tracking software for your team.