Zend Framework

Inexisting property _config in class Zend_Queue_Adapter_Db

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.9.0
  • Fix Version/s: 1.9.4
  • Component/s: Zend_Queue
  • Labels:
    None

Description

In the receive function of the Db adapter, a call to $this->_config is done in the receive method whereas it should be $this->_options
Patch:

Index: library/Zend/Queue/Adapter/Db.php
===================================================================
--- library/Zend/Queue/Adapter/Db.php	(revision 17310)
+++ library/Zend/Queue/Adapter/Db.php	(working copy)
@@ -349,7 +349,7 @@
             $db->beginTransaction();
 
             $query = $db->select();
-            if ($this->_config['options'][Zend_Db_Select::FOR_UPDATE]) {
+            if ($this->_options['options'][Zend_Db_Select::FOR_UPDATE]) {
                 // turn on forUpdate
                 $query->forUpdate();
             }

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jeroen van Dijk added a comment -

Patch file added

Show
Jeroen van Dijk added a comment - Patch file added
Hide
Permalink
Satoru Yoshida added a comment -

Solved in SVN r17318 in trunk. It will be release at 1.9.1

Show
Satoru Yoshida added a comment - Solved in SVN r17318 in trunk. It will be release at 1.9.1
Hide
Permalink
Dolf Schimmel (Freeaqingme) added a comment -

Maybe a good idea to add/update the appropriate unittests?

Show
Dolf Schimmel (Freeaqingme) added a comment - Maybe a good idea to add/update the appropriate unittests?
Hide
Permalink
Satoru Yoshida added a comment -

Do you have nice idea to check difference of results whether lacks of [Zend_Db_Select::FOR_UPDATE] ?

Show
Satoru Yoshida added a comment - Do you have nice idea to check difference of results whether lacks of [Zend_Db_Select::FOR_UPDATE] ?
Hide
Permalink
Dolf Schimmel (Freeaqingme) added a comment -

Sorry, I suck at unittests. For the moment I'm reopening this issue until there's someone who knows how to add tests for this (or someone who says it's impossible to add tests for this).

Show
Dolf Schimmel (Freeaqingme) added a comment - Sorry, I suck at unittests. For the moment I'm reopening this issue until there's someone who knows how to add tests for this (or someone who says it's impossible to add tests for this).
Hide
Permalink
Antonio Ruiz Zwollo added a comment -

The 2nd comment (Satoru Yoshida - 30/Jul/09 07:17 PM) states the fix would be released with 1.9.1. I can confirm the bug is still present in 1.9.2.

Show
Antonio Ruiz Zwollo added a comment - The 2nd comment (Satoru Yoshida - 30/Jul/09 07:17 PM) states the fix would be released with 1.9.1. I can confirm the bug is still present in 1.9.2.
Hide
Permalink
Satoru Yoshida added a comment -

Thanks confirm, Antonio. Sorry. I forgot to merge into 1.9 branch. So, I change the Fix Version to Next Minor.

Show
Satoru Yoshida added a comment - Thanks confirm, Antonio. Sorry. I forgot to merge into 1.9 branch. So, I change the Fix Version to Next Minor.
Hide
Permalink
Jeroen van Dijk added a comment -

I just saw that 1.9.3 is tagged.
Regarding the previous comment, will this fix be included in 2.0? Because it's not included in the 1.9.3 release.

Show
Jeroen van Dijk added a comment - I just saw that 1.9.3 is tagged. Regarding the previous comment, will this fix be included in 2.0? Because it's not included in the 1.9.3 release.
Hide
Permalink
Matthew Weier O'Phinney added a comment -

Jeroen - Once merged to the 1.9 release branch, we can release it. Satoru – if you could please merge it ASAP, we can include it in 1.9.4 in early October.

(BTW, next minor release will be 1.10, and is some months away; we have twice-monthly maintenance releases between minor releases.)

Show
Matthew Weier O'Phinney added a comment - Jeroen - Once merged to the 1.9 release branch, we can release it. Satoru – if you could please merge it ASAP, we can include it in 1.9.4 in early October. (BTW, next minor release will be 1.10, and is some months away; we have twice-monthly maintenance releases between minor releases.)
Hide
Permalink
Jeroen van Dijk added a comment -

Thanks for the heads up! And sorry for the misconception about minor-releases... of course 1.10 and not 2.0!

Show
Jeroen van Dijk added a comment - Thanks for the heads up! And sorry for the misconception about minor-releases... of course 1.10 and not 2.0!
Hide
Permalink
Satoru Yoshida added a comment -

Hi, Jeroen and Matthew, I just merged into 1.9 branch at SVN r18384 from trunk 17318.

So we could see it solved in next mini

Show
Satoru Yoshida added a comment - Hi, Jeroen and Matthew, I just merged into 1.9 branch at SVN r18384 from trunk 17318. So we could see it solved in next mini
Hide
Permalink
Benjamin Eberlei added a comment - - edited

Commit r18384 has another change that is not in accordance with this patch, Saturo can you comment on the diff?

http://framework.zend.com/code/browse/Standard_Library/standard/branches/release-1.9/library/Zend/Queue/Adapter/Db.php?r1=17217&r2=18384

Show
Benjamin Eberlei added a comment - - edited Commit r18384 has another change that is not in accordance with this patch, Saturo can you comment on the diff? http://framework.zend.com/code/browse/Standard_Library/standard/branches/release-1.9/library/Zend/Queue/Adapter/Db.php?r1=17217&r2=18384
Hide
Permalink
Benjamin Eberlei added a comment -

just saw this change is no problem. sorry for the buzz

Show
Benjamin Eberlei added a comment - just saw this change is no problem. sorry for the buzz

People

Vote (1)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Zend Framework. Try JIRA - bug tracking software for your team.