Zend Framework

No getAdapter() to parallel setAdapter()

Details

  • Type: Improvement Improvement
  • Status: Resolved Resolved
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9.4
  • Fix Version/s: 1.10.0
  • Component/s: Zend_Http_Client
  • Labels:
    None
  • Fix Version Priority:
    Nice to Have

Description

Zend_Http_Client contains a setAdapter() method, but not a getAdapter() method. This makes various activities such as debugging (i.e. you need to figure out which adapter class is being used) more difficult.

Issue Links

This issue is related to:
ZF-8107 Zend_Http_Clinet getAdapter() is not needed. Minor Resolved

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
michael depetrillo added a comment -

getAdapter method added.

Show
michael depetrillo added a comment - getAdapter method added.
Hide
Permalink
Kazusuke Sasezaki added a comment -

Is this issue's type a "bug"? (Maybe "Improvement".)

And, I fear that bug may be caused by getAdapter().
Adapter's method is not intend to using from other component.

If there is necessary to debugging, I suggest to doing write a Extend-Class.

Show
Kazusuke Sasezaki added a comment - Is this issue's type a "bug"? (Maybe "Improvement".) And, I fear that bug may be caused by getAdapter(). Adapter's method is not intend to using from other component. If there is necessary to debugging, I suggest to doing write a Extend-Class.
Hide
Permalink
Kazusuke Sasezaki added a comment -

I created new issue.

Show
Kazusuke Sasezaki added a comment - I created new issue.
Hide
Permalink
Satoru Yoshida added a comment -

I updated Issue Type, Affects Version and Fix Version.

Show
Satoru Yoshida added a comment - I updated Issue Type, Affects Version and Fix Version.
Hide
Permalink
Michael Stillwell added a comment -

I don't think this patch is quite right:

1. Direct references to "adapter" in request() should instead use the new getAdapter(). (Or do $adapter = $this->getAdapter() to create a local copy, etc.)

2. The getAdapter() method in Zend_Gdata_HttpClient is no longer necessary.

Show
Michael Stillwell added a comment - I don't think this patch is quite right: 1. Direct references to "adapter" in request() should instead use the new getAdapter(). (Or do $adapter = $this->getAdapter() to create a local copy, etc.) 2. The getAdapter() method in Zend_Gdata_HttpClient is no longer necessary.

People

Vote (0)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Zend Framework. Try JIRA - bug tracking software for your team.