[#ZF-8195] Call to undefined function getCommentCount() - Zend Framework Issue Tracker

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 1.9.5
Fix Version/s: 1.9.6
Component/s: Zend_Feed_Reader
Labels:
None

Description

When importing the following feed:

and then iterating through the Entries and calling getCommentCount() on each, I get the following error:

Fatal error: Call to undefined function getCommentCount() in path\to\library\Zend\Feed\Reader\Entry\Atom.php on line 298

More Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

Atom.patch

05/Nov/09 6:39 PM

0.5 kB

Thierry Jossermoz

Options
- Show All
- Show Open

Sub-Tasks

Assess unit test coverage on retrieving comment counts from Atom - are we missing the Thread ext tests?

Open

Pádraic Brady

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Thierry Jossermoz added a comment - 05/Nov/09 6:39 PM - edited

Hi,

There was a typo in Zend_Feed_Reader_Entry_Atom on line 298:

$commentcount = $this->getExtension('Thread')>getCommentCount();

Attached patch fixes the issue:

$commentcount = $this->getExtension('Thread')->getCommentCount();

Show

Thierry Jossermoz added a comment - 05/Nov/09 6:39 PM - edited Hi, There was a typo in Zend_Feed_Reader_Entry_Atom on line 298: $commentcount = $this->getExtension('Thread')>getCommentCount(); Attached patch fixes the issue: $commentcount = $this->getExtension('Thread')->getCommentCount();

Hide

Permalink

Pádraic Brady added a comment - 23/Nov/09 8:08 AM

Fixed in r19192.

Extremely silly oversight on my part - I've added a task to add test coverage for the method in Atomland which is apparently missing. May have missed it in a commit previously.

Show

Pádraic Brady added a comment - 23/Nov/09 8:08 AM Fixed in r19192. Extremely silly oversight on my part - I've added a task to add test coverage for the method in Atomland which is apparently missing. May have missed it in a commit previously.

Hide

Permalink

Pádraic Brady added a comment - 23/Nov/09 8:12 AM

Reopen to set fix version to next mini release

Show

Pádraic Brady added a comment - 23/Nov/09 8:12 AM Reopen to set fix version to next mini release

Hide

Permalink

Bradley Holt added a comment - 25/Nov/09 4:42 PM

Seems to be working fine now, thanks!

Show

Bradley Holt added a comment - 25/Nov/09 4:42 PM Seems to be working fine now, thanks!

People

Assignee:

Pádraic Brady

Reporter:

Bradley Holt

Vote (0)

Watch (1)

Dates

Created:

31/Oct/09 4:12 PM

Updated:

25/Nov/09 4:42 PM

Resolved:

23/Nov/09 8:12 AM