[#ZF-8322] Test Failures Zend_Feed_Reader Atom/RSS - Zend Framework Issue Tracker

Details

Type: Unit Tests: Problem
Status: Resolved
Priority: Major
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 1.9.6
Component/s: Zend_Feed_Reader
Labels:
None

Description

I am getting massive failures on PHP 5.3 plus PHPUnit 3.4.2:

2) Zend_Feed_Reader_Feed_RssTest::testGetsDateModifiedFromRss20
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-Saturday 07 March 2009 08 03 50 +0000
+Saturday dddd MMMMMMMMMMMM 0000000000002009 HHHH March ssss XXX

/home/benny/code/php/wsnetbeans/zftrunk/tests/Zend/Feed/Reader/Feed/RssTest.php:1945

3) Zend_Feed_Reader_Feed_RssTest::testGetsDateModifiedFromRss20_Dc10
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-Saturday 07 March 2009 08 03 50 +0000
+Saturday dddd MMMMMMMMMMMM 0000000000002009 HHHH March ssss XXX

/home/benny/code/php/wsnetbeans/zftrunk/tests/Zend/Feed/Reader/Feed/RssTest.php:1956

4) Zend_Feed_Reader_Feed_RssTest::testGetsDateModifiedFromRss094_Dc10
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-Saturday 07 March 2009 08 03 50 +0000
+Saturday dddd MMMMMMMMMMMM 0000000000002009 HHHH March ssss XXX

/home/benny/code/php/wsnetbeans/zftrunk/tests/Zend/Feed/Reader/Feed/RssTest.php:1965

5) Zend_Feed_Reader_Feed_RssTest::testGetsDateModifiedFromRss093_Dc10
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-Saturday 07 March 2009 08 03 50 +0000
+Saturday dddd MMMMMMMMMMMM 0000000000002009 HHHH March ssss XXX

/home/benny/code/php/wsnetbeans/zftrunk/tests/Zend/Feed/Reader/Feed/RssTest.php:1974

6) Zend_Feed_Reader_Feed_RssTest::testGetsDateModifiedFromRss092_Dc10
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-Saturday 07 March 2009 08 03 50 +0000
+Saturday dddd MMMMMMMMMMMM 0000000000002009 HHHH March ssss XXX

/home/benny/code/php/wsnetbeans/zftrunk/tests/Zend/Feed/Reader/Feed/RssTest.php:1983

7) Zend_Feed_Reader_Feed_RssTest::testGetsDateModifiedFromRss091_Dc10
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-Saturday 07 March 2009 08 03 50 +0000
+Saturday dddd MMMMMMMMMMMM 0000000000002009 HHHH March ssss XXX

/home/benny/code/php/wsnetbeans/zftrunk/tests/Zend/Feed/Reader/Feed/RssTest.php:1992

8) Zend_Feed_Reader_Feed_RssTest::testGetsDateModifiedFromRss10_Dc10
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-Saturday 07 March 2009 08 03 50 +0000
+Saturday dddd MMMMMMMMMMMM 0000000000002009 HHHH March ssss XXX

/home/benny/code/php/wsnetbeans/zftrunk/tests/Zend/Feed/Reader/Feed/RssTest.php:2001

9) Zend_Feed_Reader_Feed_RssTest::testGetsDateModifiedFromRss090_Dc10
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-Saturday 07 March 2009 08 03 50 +0000
+Saturday dddd MMMMMMMMMMMM 0000000000002009 HHHH March ssss XXX

/home/benny/code/php/wsnetbeans/zftrunk/tests/Zend/Feed/Reader/Feed/RssTest.php:2010

10) Zend_Feed_Reader_Feed_RssTest::testGetsDateModifiedFromRss20_Dc11
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-Saturday 07 March 2009 08 03 50 +0000
+Saturday dddd MMMMMMMMMMMM 0000000000002009 HHHH March ssss XXX

/home/benny/code/php/wsnetbeans/zftrunk/tests/Zend/Feed/Reader/Feed/RssTest.php:2021

11) Zend_Feed_Reader_Feed_RssTest::testGetsDateModifiedFromRss094_Dc11
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-Saturday 07 March 2009 08 03 50 +0000
+Saturday dddd MMMMMMMMMMMM 0000000000002009 HHHH March ssss XXX

/home/benny/code/php/wsnetbeans/zftrunk/tests/Zend/Feed/Reader/Feed/RssTest.php:2030

12) Zend_Feed_Reader_Feed_RssTest::testGetsDateModifiedFromRss093_Dc11
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-Saturday 07 March 2009 08 03 50 +0000
+Saturday dddd MMMMMMMMMMMM 0000000000002009 HHHH March ssss XXX

/home/benny/code/php/wsnetbeans/zftrunk/tests/Zend/Feed/Reader/Feed/RssTest.php:2039

13) Zend_Feed_Reader_Feed_RssTest::testGetsDateModifiedFromRss092_Dc11
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-Saturday 07 March 2009 08 03 50 +0000
+Saturday dddd MMMMMMMMMMMM 0000000000002009 HHHH March ssss XXX

/home/benny/code/php/wsnetbeans/zftrunk/tests/Zend/Feed/Reader/Feed/RssTest.php:2048

14) Zend_Feed_Reader_Feed_RssTest::testGetsDateModifiedFromRss091_Dc11
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-Saturday 07 March 2009 08 03 50 +0000
+Saturday dddd MMMMMMMMMMMM 0000000000002009 HHHH March ssss XXX

/home/benny/code/php/wsnetbeans/zftrunk/tests/Zend/Feed/Reader/Feed/RssTest.php:2057

15) Zend_Feed_Reader_Feed_RssTest::testGetsDateModifiedFromRss10_Dc11
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-Saturday 07 March 2009 08 03 50 +0000
+Saturday dddd MMMMMMMMMMMM 0000000000002009 HHHH March ssss XXX

/home/benny/code/php/wsnetbeans/zftrunk/tests/Zend/Feed/Reader/Feed/RssTest.php:2066

16) Zend_Feed_Reader_Feed_RssTest::testGetsDateModifiedFromRss090_Dc11
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-Saturday 07 March 2009 08 03 50 +0000
+Saturday dddd MMMMMMMMMMMM 0000000000002009 HHHH March ssss XXX

/home/benny/code/php/wsnetbeans/zftrunk/tests/Zend/Feed/Reader/Feed/RssTest.php:2075

17) Zend_Feed_Reader_Feed_RssTest::testGetsDateModifiedFromRss20_atom10
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-Saturday 07 March 2009 08 03 50 +0000
+Saturday dddd MMMMMMMMMMMM 0000000000002009 HHHH March ssss XXX

/home/benny/code/php/wsnetbeans/zftrunk/tests/Zend/Feed/Reader/Feed/RssTest.php:2086

18) Zend_Feed_Reader_Feed_RssTest::testGetsDateModifiedFromRss094_atom10
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-Saturday 07 March 2009 08 03 50 +0000
+Saturday dddd MMMMMMMMMMMM 0000000000002009 HHHH March ssss XXX

/home/benny/code/php/wsnetbeans/zftrunk/tests/Zend/Feed/Reader/Feed/RssTest.php:2095

19) Zend_Feed_Reader_Feed_RssTest::testGetsDateModifiedFromRss093_atom10
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-Saturday 07 March 2009 08 03 50 +0000
+Saturday dddd MMMMMMMMMMMM 0000000000002009 HHHH March ssss XXX

/home/benny/code/php/wsnetbeans/zftrunk/tests/Zend/Feed/Reader/Feed/RssTest.php:2104

20) Zend_Feed_Reader_Feed_RssTest::testGetsDateModifiedFromRss092_atom10
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-Saturday 07 March 2009 08 03 50 +0000
+Saturday dddd MMMMMMMMMMMM 0000000000002009 HHHH March ssss XXX

/home/benny/code/php/wsnetbeans/zftrunk/tests/Zend/Feed/Reader/Feed/RssTest.php:2113

21) Zend_Feed_Reader_Feed_RssTest::testGetsDateModifiedFromRss091_atom10
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-Saturday 07 March 2009 08 03 50 +0000
+Saturday dddd MMMMMMMMMMMM 0000000000002009 HHHH March ssss XXX

/home/benny/code/php/wsnetbeans/zftrunk/tests/Zend/Feed/Reader/Feed/RssTest.php:2122

22) Zend_Feed_Reader_Feed_RssTest::testGetsDateModifiedFromRss10_atom10
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-Saturday 07 March 2009 08 03 50 +0000
+Saturday dddd MMMMMMMMMMMM 0000000000002009 HHHH March ssss XXX

/home/benny/code/php/wsnetbeans/zftrunk/tests/Zend/Feed/Reader/Feed/RssTest.php:2131

23) Zend_Feed_Reader_Feed_RssTest::testGetsDateModifiedFromRss090_atom10
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-Saturday 07 March 2009 08 03 50 +0000
+Saturday dddd MMMMMMMMMMMM 0000000000002009 HHHH March ssss XXX

/home/benny/code/php/wsnetbeans/zftrunk/tests/Zend/Feed/Reader/Feed/RssTest.php:2140

24) Zend_Feed_Reader_Entry_RssTest::testGetsDateModifiedFromRss20
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-Saturday 07 March 2009 08 03 50 +0000
+Saturday dddd MMMMMMMMMMMM 0000000000002009 HHHH March ssss XXX

/home/benny/code/php/wsnetbeans/zftrunk/tests/Zend/Feed/Reader/Entry/RssTest.php:1783

25) Zend_Feed_Reader_Entry_RssTest::testGetsDateModifiedFromRss20_Dc10
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-Saturday 07 March 2009 08 03 50 +0000
+Saturday dddd MMMMMMMMMMMM 0000000000002009 HHHH March ssss XXX

/home/benny/code/php/wsnetbeans/zftrunk/tests/Zend/Feed/Reader/Entry/RssTest.php:1794

26) Zend_Feed_Reader_Entry_RssTest::testGetsDateModifiedFromRss094_Dc10
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-Saturday 07 March 2009 08 03 50 +0000
+Saturday dddd MMMMMMMMMMMM 0000000000002009 HHHH March ssss XXX

/home/benny/code/php/wsnetbeans/zftrunk/tests/Zend/Feed/Reader/Entry/RssTest.php:1803

27) Zend_Feed_Reader_Entry_RssTest::testGetsDateModifiedFromRss093_Dc10
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-Saturday 07 March 2009 08 03 50 +0000
+Saturday dddd MMMMMMMMMMMM 0000000000002009 HHHH March ssss XXX

/home/benny/code/php/wsnetbeans/zftrunk/tests/Zend/Feed/Reader/Entry/RssTest.php:1812

28) Zend_Feed_Reader_Entry_RssTest::testGetsDateModifiedFromRss092_Dc10
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-Saturday 07 March 2009 08 03 50 +0000
+Saturday dddd MMMMMMMMMMMM 0000000000002009 HHHH March ssss XXX

/home/benny/code/php/wsnetbeans/zftrunk/tests/Zend/Feed/Reader/Entry/RssTest.php:1821

29) Zend_Feed_Reader_Entry_RssTest::testGetsDateModifiedFromRss091_Dc10
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-Saturday 07 March 2009 08 03 50 +0000
+Saturday dddd MMMMMMMMMMMM 0000000000002009 HHHH March ssss XXX

/home/benny/code/php/wsnetbeans/zftrunk/tests/Zend/Feed/Reader/Entry/RssTest.php:1830

30) Zend_Feed_Reader_Entry_RssTest::testGetsDateModifiedFromRss10_Dc10
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-Saturday 07 March 2009 08 03 50 +0000
+Saturday dddd MMMMMMMMMMMM 0000000000002009 HHHH March ssss XXX

/home/benny/code/php/wsnetbeans/zftrunk/tests/Zend/Feed/Reader/Entry/RssTest.php:1839

31) Zend_Feed_Reader_Entry_RssTest::testGetsDateModifiedFromRss090_Dc10
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-Saturday 07 March 2009 08 03 50 +0000
+Saturday dddd MMMMMMMMMMMM 0000000000002009 HHHH March ssss XXX

/home/benny/code/php/wsnetbeans/zftrunk/tests/Zend/Feed/Reader/Entry/RssTest.php:1848

32) Zend_Feed_Reader_Entry_RssTest::testGetsDateModifiedFromRss20_Dc11
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-Saturday 07 March 2009 08 03 50 +0000
+Saturday dddd MMMMMMMMMMMM 0000000000002009 HHHH March ssss XXX

/home/benny/code/php/wsnetbeans/zftrunk/tests/Zend/Feed/Reader/Entry/RssTest.php:1859

33) Zend_Feed_Reader_Entry_RssTest::testGetsDateModifiedFromRss094_Dc11
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-Saturday 07 March 2009 08 03 50 +0000
+Saturday dddd MMMMMMMMMMMM 0000000000002009 HHHH March ssss XXX

/home/benny/code/php/wsnetbeans/zftrunk/tests/Zend/Feed/Reader/Entry/RssTest.php:1868

34) Zend_Feed_Reader_Entry_RssTest::testGetsDateModifiedFromRss093_Dc11
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-Saturday 07 March 2009 08 03 50 +0000
+Saturday dddd MMMMMMMMMMMM 0000000000002009 HHHH March ssss XXX

/home/benny/code/php/wsnetbeans/zftrunk/tests/Zend/Feed/Reader/Entry/RssTest.php:1877

35) Zend_Feed_Reader_Entry_RssTest::testGetsDateModifiedFromRss092_Dc11
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-Saturday 07 March 2009 08 03 50 +0000
+Saturday dddd MMMMMMMMMMMM 0000000000002009 HHHH March ssss XXX

/home/benny/code/php/wsnetbeans/zftrunk/tests/Zend/Feed/Reader/Entry/RssTest.php:1886

36) Zend_Feed_Reader_Entry_RssTest::testGetsDateModifiedFromRss091_Dc11
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-Saturday 07 March 2009 08 03 50 +0000
+Saturday dddd MMMMMMMMMMMM 0000000000002009 HHHH March ssss XXX

/home/benny/code/php/wsnetbeans/zftrunk/tests/Zend/Feed/Reader/Entry/RssTest.php:1895

37) Zend_Feed_Reader_Entry_RssTest::testGetsDateModifiedFromRss10_Dc11
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-Saturday 07 March 2009 08 03 50 +0000
+Saturday dddd MMMMMMMMMMMM 0000000000002009 HHHH March ssss XXX

/home/benny/code/php/wsnetbeans/zftrunk/tests/Zend/Feed/Reader/Entry/RssTest.php:1904

38) Zend_Feed_Reader_Entry_RssTest::testGetsDateModifiedFromRss090_Dc11
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-Saturday 07 March 2009 08 03 50 +0000
+Saturday dddd MMMMMMMMMMMM 0000000000002009 HHHH March ssss XXX

/home/benny/code/php/wsnetbeans/zftrunk/tests/Zend/Feed/Reader/Entry/RssTest.php:1913

39) Zend_Feed_Reader_Feed_AtomTest::testGetsDateCreatedFromAtom03
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-Saturday 07 March 2009 08 03 50 +0000
+Saturday dddd MMMMMMMMMMMM 0000000000002009 HHHH March ssss XXX

/home/benny/code/php/wsnetbeans/zftrunk/tests/Zend/Feed/Reader/Feed/AtomTest.php:136

40) Zend_Feed_Reader_Feed_AtomTest::testGetsDateCreatedFromAtom10
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-Saturday 07 March 2009 08 03 50 +0000
+Saturday dddd MMMMMMMMMMMM 0000000000002009 HHHH March ssss XXX

/home/benny/code/php/wsnetbeans/zftrunk/tests/Zend/Feed/Reader/Feed/AtomTest.php:146

41) Zend_Feed_Reader_Feed_AtomTest::testGetsDateModifiedFromAtom03
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-Saturday 07 March 2009 08 03 50 +0000
+Saturday dddd MMMMMMMMMMMM 0000000000002009 HHHH March ssss XXX

/home/benny/code/php/wsnetbeans/zftrunk/tests/Zend/Feed/Reader/Feed/AtomTest.php:159

42) Zend_Feed_Reader_Feed_AtomTest::testGetsDateModifiedFromAtom10
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-Saturday 07 March 2009 08 03 50 +0000
+Saturday dddd MMMMMMMMMMMM 0000000000002009 HHHH March ssss XXX

/home/benny/code/php/wsnetbeans/zftrunk/tests/Zend/Feed/Reader/Feed/AtomTest.php:169

43) Zend_Feed_Reader_Entry_AtomTest::testGetsDateCreatedFromAtom03
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-Saturday 07 March 2009 08 03 50 +0000
+Saturday dddd MMMMMMMMMMMM 0000000000002009 HHHH March ssss XXX

/home/benny/code/php/wsnetbeans/zftrunk/tests/Zend/Feed/Reader/Entry/AtomTest.php:80

44) Zend_Feed_Reader_Entry_AtomTest::testGetsDateCreatedFromAtom10
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-Saturday 07 March 2009 08 03 50 +0000
+Saturday dddd MMMMMMMMMMMM 0000000000002009 HHHH March ssss XXX

/home/benny/code/php/wsnetbeans/zftrunk/tests/Zend/Feed/Reader/Entry/AtomTest.php:90

45) Zend_Feed_Reader_Entry_AtomTest::testGetsDateModifiedFromAtom03
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-Saturday 07 March 2009 08 03 50 +0000
+Saturday dddd MMMMMMMMMMMM 0000000000002009 HHHH March ssss XXX

/home/benny/code/php/wsnetbeans/zftrunk/tests/Zend/Feed/Reader/Entry/AtomTest.php:103

46) Zend_Feed_Reader_Entry_AtomTest::testGetsDateModifiedFromAtom10
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-Saturday 07 March 2009 08 03 50 +0000
+Saturday dddd MMMMMMMMMMMM 0000000000002009 HHHH March ssss XXX

I have the following modules installed:

[PHP Modules]
bz2
calendar
Core
ctype
curl
date
dom
ereg
exif
fileinfo
filter
gd
gearman
hash
iconv
json
ldap
libxml
mbstring
mcrypt
mysql
mysqli
pcre
PDO
pdo_mysql
pdo_pgsql
pdo_sqlite
pgsql
Phar
posix
Reflection
session
SimpleXML
SPL
SQLite
sqlite3
standard
tidy
tokenizer
xdebug
xml
xmlreader
xmlwriter
xsl
zip
zlib

[Zend Modules]
Xdebug

Options
- Show All
- Show Open

Sub-Tasks

Include a documentation note about the use of Zend_Date as a return type from Zend_Feed_Reader methods

Open

Pádraic Brady

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Pádraic Brady added a comment - 17/Nov/09 9:06 AM

Just to confirm, there are all Date related?

All the dates are handled at a distance by Zend_Date which is where they are parsed and re-formatted. From the test results, the input value is being correctly received (Atom and RSS use different date standards), but the output formatting (via Zend_Date) is malformed. There's no custom date handling, or other code capable of change, outside of that.

Do the tests for Zend_Date show any failures under your system?

Show

Pádraic Brady added a comment - 17/Nov/09 9:06 AM Just to confirm, there are all Date related? All the dates are handled at a distance by Zend_Date which is where they are parsed and re-formatted. From the test results, the input value is being correctly received (Atom and RSS use different date standards), but the output formatting (via Zend_Date) is malformed. There's no custom date handling, or other code capable of change, outside of that. Do the tests for Zend_Date show any failures under your system?

Hide

Permalink

Benjamin Eberlei added a comment - 17/Nov/09 9:45 AM

Zend Date is working perfectly, which is odd.

Show

Benjamin Eberlei added a comment - 17/Nov/09 9:45 AM Zend Date is working perfectly, which is odd.

Hide

Permalink

Dolf Schimmel (Freeaqingme) added a comment - 17/Nov/09 9:51 AM

The tests dont happen to be locale dependent?

Show

Dolf Schimmel (Freeaqingme) added a comment - 17/Nov/09 9:51 AM The tests dont happen to be locale dependent?

Hide

Permalink

Pádraic Brady added a comment - 17/Nov/09 11:20 AM

Locale shouldn't be an issue. The only part of Zend_Date of relevance in the tests is parsing an ISO or RFC standard date, and outputting the same information using the test-defined format (just a long string description). The step used simply ensures all dates are resolved to the same format in method results.

I'll do some testing on my side when I have PHP5.3 machine in front of me. While many tests are failing, it's obviously one single behaviour so fixing it should, with luck, be a simple matter.

Show

Pádraic Brady added a comment - 17/Nov/09 11:20 AM Locale shouldn't be an issue. The only part of Zend_Date of relevance in the tests is parsing an ISO or RFC standard date, and outputting the same information using the test-defined format (just a long string description). The step used simply ensures all dates are resolved to the same format in method results. I'll do some testing on my side when I have PHP5.3 machine in front of me. While many tests are failing, it's obviously one single behaviour so fixing it should, with luck, be a simple matter.

Hide

Permalink

Thomas Weidner added a comment - 18/Nov/09 3:08 AM

Detaching Zend_Date from affected components as this is a Zend_Feed unittest error

Show

Thomas Weidner added a comment - 18/Nov/09 3:08 AM Detaching Zend_Date from affected components as this is a Zend_Feed unittest error

Hide

Permalink

Thomas Weidner added a comment - 18/Nov/09 3:15 AM

Just as hint:
Looks like the used format for Zend_Date has been set to "GNU" instead of "ISO". It's an static option.

You should ensure in your unittests to set the options for Zend_Date while doing the test setup.
This could happen due to previous run code, or through other unit tests run previously.

Show

Thomas Weidner added a comment - 18/Nov/09 3:15 AM Just as hint: Looks like the used format for Zend_Date has been set to "GNU" instead of "ISO". It's an static option. You should ensure in your unittests to set the options for Zend_Date while doing the test setup. This could happen due to previous run code, or through other unit tests run previously.

Hide

Permalink

Thomas Weidner added a comment - 18/Nov/09 3:16 AM

Just as hint:
Looks like the used format for Zend_Date has been set to "GNU" instead of "ISO". It's an static option.

You should ensure in your unittests to set the options for Zend_Date while doing the test setup.
This could happen due to previous run code, or through other unit tests run previously.

Show

Thomas Weidner added a comment - 18/Nov/09 3:16 AM Just as hint: Looks like the used format for Zend_Date has been set to "GNU" instead of "ISO". It's an static option. You should ensure in your unittests to set the options for Zend_Date while doing the test setup. This could happen due to previous run code, or through other unit tests run previously.

Hide

Permalink

Pádraic Brady added a comment - 18/Nov/09 3:54 AM

Thanks for the hint Thomas - I'll see if that makes a difference, and clean up the setup/teardown to account for any static options I might be missing.

Show

Pádraic Brady added a comment - 18/Nov/09 3:54 AM Thanks for the hint Thomas - I'll see if that makes a difference, and clean up the setup/teardown to account for any static options I might be missing.

Hide

Permalink

Pádraic Brady added a comment - 18/Nov/09 5:21 AM

Just to clarify a slight oversight on my part (I'll clarify this in the docs later too) - Zend_Feed_Reader does not attempt to output a normalised date from Zend_Date. It simply returns the Zend_Date object itself from all date methods, which allows the user to define output formatting and such on their own terms. Neither does Zend_Feed_Reader tamper with any Zend_Date options. Therefore, the formatting bug is a bug within the Tests where output is required to verify the correct date was parsed from the output. This was probably not the best approach to begin with - comparing two Zend_Date objects would have worked without needing explicit output - so my bad . The actual component itself should function perfectly as a result - this is an error in the tests, not the component.

The docs will clarify the treatment/use of Zend_Date by adding a note indicating that the returned Zend_Date follows the statically set options, and that users should take this into account when getting a date string.

As a result, I'm recategorising this issue as a "Unit Tests: Problem" issue. I'm working on a fix to the unit tests now to ensure the correct options are set during setup, and the originals swapped back during teardown. If the options are an issue, it won't be hard to replicate by fudging the options a bit to find which one is responsible. During tomorrow I'll implement an output independent version of the same tests to simplify it more.

Show

Pádraic Brady added a comment - 18/Nov/09 5:21 AM Just to clarify a slight oversight on my part (I'll clarify this in the docs later too) - Zend_Feed_Reader does not attempt to output a normalised date from Zend_Date. It simply returns the Zend_Date object itself from all date methods, which allows the user to define output formatting and such on their own terms. Neither does Zend_Feed_Reader tamper with any Zend_Date options. Therefore, the formatting bug is a bug within the Tests where output is required to verify the correct date was parsed from the output. This was probably not the best approach to begin with - comparing two Zend_Date objects would have worked without needing explicit output - so my bad

. The actual component itself should function perfectly as a result - this is an error in the tests, not the component. The docs will clarify the treatment/use of Zend_Date by adding a note indicating that the returned Zend_Date follows the statically set options, and that users should take this into account when getting a date string. As a result, I'm recategorising this issue as a "Unit Tests: Problem" issue. I'm working on a fix to the unit tests now to ensure the correct options are set during setup, and the originals swapped back during teardown. If the options are an issue, it won't be hard to replicate by fudging the options a bit to find which one is responsible. During tomorrow I'll implement an output independent version of the same tests to simplify it more.

Hide

Permalink

Pádraic Brady added a comment - 18/Nov/09 5:45 AM

I confirmed the cause is Zend_Date having a format_type option set to "php" instead of "iso". Someone else's tests are leaking settings. I'll try to find the offending tests - presumably something higher up the list.

Benjamin - can you confirm if running Zend_Feed tests by themselves pass correctly?

Show

Pádraic Brady added a comment - 18/Nov/09 5:45 AM I confirmed the cause is Zend_Date having a format_type option set to "php" instead of "iso". Someone else's tests are leaking settings. I'll try to find the offending tests - presumably something higher up the list. Benjamin - can you confirm if running Zend_Feed tests by themselves pass correctly?

Hide

Permalink

Pádraic Brady added a comment - 18/Nov/09 6:06 AM

Committed r19017 to trunk (merged to release-1.9 branch) which locks all Zend_Feed_Reader tests using Zend_Date into ISO formatting. The original settings are restored during teardown. This should ensure PHP formatting of dates cannot be leaked from other test suites (as seems to be the current case).

The reporter can confirm the fix is applicable - the issue won't be formally closed until Benjamin confirms.

Show

Pádraic Brady added a comment - 18/Nov/09 6:06 AM Committed r19017 to trunk (merged to release-1.9 branch) which locks all Zend_Feed_Reader tests using Zend_Date into ISO formatting. The original settings are restored during teardown. This should ensure PHP formatting of dates cannot be leaked from other test suites (as seems to be the current case). The reporter can confirm the fix is applicable - the issue won't be formally closed until Benjamin confirms.

Hide

Permalink

Pádraic Brady added a comment - 20/Nov/09 12:34 PM

Fixed in trunk and release branch - the tests with issues are now rewritten to avoid string comparisons depending on a default locale. OP can confirm and reopen if any other locale issues to be aware of.

Show

Pádraic Brady added a comment - 20/Nov/09 12:34 PM Fixed in trunk and release branch - the tests with issues are now rewritten to avoid string comparisons depending on a default locale. OP can confirm and reopen if any other locale issues to be aware of.

People

Assignee:

Pádraic Brady

Reporter:

Benjamin Eberlei

Vote (0)

Watch (1)

Dates

Created:

17/Nov/09 8:26 AM

Updated:

20/Nov/09 12:34 PM

Resolved:

20/Nov/09 12:34 PM