Zend Framework

Zend_Feed_Reader::findFeedLinks() doesn't handle relative feed URIs

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.9.5
  • Fix Version/s: 1.9.6
  • Component/s: Zend_Feed_Reader
  • Labels:
    None

Description

Zend_Feed_Reader::findFeedLinks() doesn't handle relative feed URIs:

Code:

print_r(Zend_Feed_Reader::findFeedLinks('http://meiobit.com'));

Output:

stdClass Object
(
    [rss] => /rss.xml
)

Expected:

stdClass Object
(
    [rss] => http://meiobit.com/rss.xml
)
  1. FeedSet.patch
    20/Nov/09 11:47 AM
    1 kB
    Jan Sorgalla
  2. ReaderTest.patch
    20/Nov/09 11:47 AM
    1 kB
    Jan Sorgalla

Activity

Hide
Pádraic Brady added a comment -

Fixed in r19103.

Show
Pádraic Brady added a comment - Fixed in r19103.
Hide
Jan Sorgalla added a comment -

This will still fail on uri's with paths, ie.:

http://example.com/sub:
<link rel="alternate" type="application/rss+xml" href="/feed.rss" />

or

http://example.com/sub:
<link rel="alternate" type="application/rss+xml" href="../feed.rss" />

Show
Jan Sorgalla added a comment - This will still fail on uri's with paths, ie.: http://example.com/sub: <link rel="alternate" type="application/rss+xml" href="/feed.rss" /> or http://example.com/sub: <link rel="alternate" type="application/rss+xml" href="../feed.rss" />
Hide
Jan Sorgalla added a comment -

Attached patches fixing the uri with paths (reason for reopening the issue)

Show
Jan Sorgalla added a comment - Attached patches fixing the uri with paths (reason for reopening the issue)
Hide
Pádraic Brady added a comment -

Patches applied in r19136.

On a separate note - very good catch!

Show
Pádraic Brady added a comment - Patches applied in r19136. On a separate note - very good catch!

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: