Details
-
Type:
Bug
-
Status:
Resolved
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 1.9.5
-
Fix Version/s: 1.10.0
-
Component/s: Zend_Controller
-
Labels:None
-
Fix Version Priority:Must Have
Description
The following (around line 337) from Zend_Controller_Dispatcher_Standard should be refactored:
$dispatchDir = $this->getDispatchDirectory(); $loadFile = $dispatchDir . DIRECTORY_SEPARATOR . $this->classToFilename($className); if (!include_once $loadFile) { require_once 'Zend/Controller/Dispatcher/Exception.php'; throw new Zend_Controller_Dispatcher_Exception('Cannot load controller class "' . $className . '" from file "' . $loadFile . "'"); }
include_once statement can generate a Warning if the file does not exists
It should be @include_once or check with file_exists
I'm not able to reopen the issue
ZF-4736So, I clone it to say :
Hello,
This issue should be reopened because the include_once statement can generate a Warning if the file does not exists.
It should be @include_once or check with file_exists
Thanks to fix this
Cheers,
Raphaël Dehousse
ZF-4736So, I clone it to say : Hello, This issue should be reopened because the include_once statement can generate a Warning if the file does not exists. It should be @include_once or check with file_exists Thanks to fix this Cheers, Raphaël Dehousse