Zend Framework

Wrong desc

Details

  • Type: Docs:  Problem Docs: Problem
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.9.6
  • Fix Version/s: 1.10.0
  • Component/s: Zend_Controller
  • Labels:
    None
  • Language:
    English

Description

Zend_Controller_Front (#511)
Shouldn't return type be Zend_Controller_Router_Rewrite instead of Zend_Controller_Router_Interface?

Zend_Controller_Router_Route (#156)
Duplicated @param $reqs and missing @param $locale desc.

Activity

Hide
Matthew Weier O'Phinney added a comment -

re: "Shouldn't return type be Zend_Controller_Router_Rewrite instead of Zend_Controller_Router_Interface" – No. While Router_Rewrite is the default router shipped with ZF, you can attach different router classes that implement Zend_Controller_Router_Interface; in fact, Router_Rewrite is itself an implementation of it.

The second point is valid, however.

Show
Matthew Weier O'Phinney added a comment - re: "Shouldn't return type be Zend_Controller_Router_Rewrite instead of Zend_Controller_Router_Interface" – No. While Router_Rewrite is the default router shipped with ZF, you can attach different router classes that implement Zend_Controller_Router_Interface; in fact, Router_Rewrite is itself an implementation of it. The second point is valid, however.
Hide
Marco Kaiser added a comment -

Zend_Controller_Front line 511 its correct so because the base class is _interface
The double documented thing will be fixed

Show
Marco Kaiser added a comment - Zend_Controller_Front line 511 its correct so because the base class is _interface The double documented thing will be fixed
Hide
Marco Kaiser added a comment -

fixed in r19242

Show
Marco Kaiser added a comment - fixed in r19242

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: