ZF-8595: Zend_Gdata_App_FeedEntryParent::setEtag() DocBlock (and others) Incorrect

Issue Type:
Bug
Created:
2009-12-21T11:30:33.000+0000
Last Updated:
2009-12-21T14:08:23.000+0000
Status:
Resolved
Fix version(s):
  • 1.9.7 (11/Jan/10)
Reporter:
Bradley Holt (bradley.holt)
Assignee:
Trevor Johns (tjohns)
Tags:
  • Zend_Gdata
Related issues:
Attachments:

Description

The DocBlock comment for {{Zend_Gdata_App_FeedEntryParent::setEtag()}} incorrectly reports its return type as {{Zend_Gdata_App_Entry}} (since it's providing a fluent interface). The actual return type is {{Zend_Gdata_App_FeedEntryParent}}. There are also several DocBlocks in the same file that show a return type of {{Zend_Gdata_App_Feed_Entry_Parent}} where the actual return type is {{Zend_Gdata_App_FeedEntryParent}}.

Comments

Posted by Trevor Johns (tjohns) on 2009-12-21T14:02:56.000+0000

Fixed for 1.10.

{quote} commit aebccca67b5cb32dc15cbf55db6fd15f97acdf50 Author: tjohns <tjohns@44c647ce-9c0f-0410-b52a-842ac1e357ba> Date: Mon Dec 21 21:52:42 2009 +0000

ZF-8595: Fix incorrect return types in header docs for Zend_Gdata_App_FeedEntryParent.

Methods that return a fluent interface should be returning Zend_Gdata_App_FeedEntryParent, not
Zend_Gdata_App_Entry or Zend_Gdata_App_Feed_Entry_Parent.

git-svn-id: <a rel="nofollow" href="http://framework.zend.com/svn/framework/standard/trunk@19866">http://framework.zend.com/svn/framework/&hellip;</a> 44c647ce-9c0f-0410-b52a-842ac1e357ba

{quote}

{quote} commit 6f052ddc0f946d442acf0fc590980a0426cf0ff7 Author: tjohns <tjohns@44c647ce-9c0f-0410-b52a-842ac1e357ba> Date: Mon Dec 21 22:01:11 2009 +0000

Merge r19866 from trunk to release-1.10.

ZF-8595: Fix incorrect return types in header docs for Zend_Gdata_App_FeedEntryParent.

Methods that return a fluent interface should be returning Zend_Gdata_App_FeedEntryParent, not
Zend_Gdata_App_Entry or Zend_Gdata_App_Feed_Entry_Parent.

git-svn-id: <a rel="nofollow" href="http://framework.zend.com/svn/framework/standard/branches/release-1.10@19868">http://framework.zend.com/svn/framework/&hellip;</a> 44c647ce-9c0f-0410-b52a-842ac1e357ba

{quote}

Posted by Trevor Johns (tjohns) on 2009-12-21T14:08:23.000+0000

Since this is a simple change, I've merged it back into release-1.9. This should be fixed in 1.9.7.

{quote} commit b6f72626408aa63dfd9bc6c66a5cb1992775df8d Author: tjohns <tjohns@44c647ce-9c0f-0410-b52a-842ac1e357ba> Date: Mon Dec 21 22:06:12 2009 +0000

Merge r19866 from trunk to release-1.9.

ZF-8595: Fix incorrect return types in header docs for Zend_Gdata_App_FeedEntryParent.

Methods that return a fluent interface should be returning Zend_Gdata_App_FeedEntryParent, not
Zend_Gdata_App_Entry or Zend_Gdata_App_Feed_Entry_Parent.

git-svn-id: <a rel="nofollow" href="http://framework.zend.com/svn/framework/standard/branches/release-1.9@19870">http://framework.zend.com/svn/framework/&hellip;</a> 44c647ce-9c0f-0410-b52a-842ac1e357ba

{quote}