ZF-8790: CLONE -Strict Standards: Only variables should be passed by reference in Zend/Db/Select.php on line 246

Issue Type:
Bug
Created:
2010-01-12T08:38:07.000+0000
Last Updated:
2010-01-12T22:16:09.000+0000
Status:
Resolved
Fix version(s):
  • 1.10.0 (27/Jan/10)
Reporter:
Daniel Ott (thedott)
Assignee:
Satoru Yoshida (satoruyoshida)
Tags:
  • Zend_Db_Select
Related issues:
Attachments:

Description

The error comes from lin 246 where array_keys() is wrapped in current().

This is triggering the error: Only variables should be passed by reference


if ($correlationName === null && count($this->_parts[self::FROM])) {
 $correlationName = current(array_keys($this->_parts[self::FROM]));
}

This can be prevented with:


if ($correlationName === null && count($this->_parts[self::FROM])) {
 $correlationNameKeys = array_keys($this->_parts[self::FROM]);
 $correlationName = current($correlationNameKeys);
}

Comments

Posted by Daniel Ott (thedott) on 2010-01-12T08:38:51.000+0000

Release 1.9.7 has the old code still in place.

Posted by Satoru Yoshida (satoruyoshida) on 2010-01-12T22:16:09.000+0000

It is duplicate of ZF-7975.