ZF-8836: Zend_Validate_Barcode_AdapterAbstract uses call_user_func_array instead of call_user_func

Description

Which results in an invalid argument error (even when unit testing)


Index: library/Zend/Validate/Barcode/AdapterAbstract.php
===================================================================
--- library/Zend/Validate/Barcode/AdapterAbstract.php   (revision 20329)
+++ library/Zend/Validate/Barcode/AdapterAbstract.php   (working copy)
@@ -139,7 +139,7 @@
         $checksum = $this->getChecksum();
         if (!empty($checksum)) {
             if (method_exists($this, $checksum)) {
-                return call_user_func_array(array($this, $checksum), $value);
+                return call_user_func(array($this, $checksum), $value);
             }
         }
 

Comments

There is no error running unittests Please give us reproducable informations

Even if you're not getting errors, don't you agree it should change since the call_user_func_array expects an array as second argument, but a string is given in this case? So sooner or later (in this case: sooner), this will lead to errors or warnings.

Please see http://php.net/manual/en/…. Apparently, PHP5.2 does not enforce it, but it will cause trouble if this code stays the same.

BTW: I am running php 5.3.0, in which it is enforced.

Changed with r20509

PS: I still don't see a problem.. but I deleted the forcing of $value to array and the array-callback itself.