ZF-8874: Navigation Menu View Helper Output Without Whitespace

Issue Type:
Improvement
Created:
2010-01-19T14:08:38.000+0000
Last Updated:
2013-01-22T09:45:46.000+0000
Status:
Resolved
Fix version(s):
  • 1.12.2 (25/Feb/13)
Reporter:
Anders Petersen (anpeters)
Assignee:
Frank Brückner (frosch)
Tags:
  • Zend_Navigation
  • After1.12.0
  • state:patch-ready-for-review
  • zf-crteam-padraic
  • zf-crteam-priority
  • zf-crteam-review
Related issues:
Attachments:

Description

I've been working with Zend Navigation, but today I ran into a little problem with the way it adds whitespace around the LI. I wanted to display the LIs next to each other, and used the CSS display value inline-block. But because of the whitespace in the HTML, specifically the newline between the ending and opening LI, there is a gap between the LIs. There is an example of what I mean here: http://pawlikserver.com/tests/whitespaceTest.html

So, I was hoping it might be possible to add an option to disable output of the excess whitespace. For example FormatOutput, since that is already used in the Sitemap view helper.

Comments

Posted by Kai Uwe (kaiuwe) on 2011-01-28T07:20:49.000+0000

If we have separators for list and list items, we can manipulate the output.

Posted by Kai Uwe (kaiuwe) on 2011-07-25T12:57:46.000+0000

I think we also need to add a new option:


$indent      = $this->getIndent(); // Zend_View_Helper_Navigation_HelperAbstract
$innerIndent = $this->getInnerIndent; // Zend_View_Helper_Navigation_Menu - NEW!

$indent . '
'; $indent . $innerIndent . 'foo'; $indent . $innerIndent . 'bar'; $indent . '';

Posted by Frank Brückner (frosch) on 2011-09-06T09:35:07.000+0000

Tasks: * Move {{$_formatOutput}}, {{getFormatOutput()}} and {{setFormatOutput()}} from {{Zend_View_Helper_Navigation_Sitemap}} to {{Zend_View_Helper_Navigation_HelperAbstract}} * Add method {{setEOL}} and {{getEOL}} to {{Zend_View_Helper_Navigation_HelperAbstract}} (standard is {{self::EOL}} and is respects the option "formatOutput") * Change all concrete helpers to use {{getEOL}} instead of {{self::EOL}} * Complete rework of the use of indentation (is hard coded!)

Posted by Frank Brückner (frosch) on 2011-11-15T21:20:36.000+0000

Patch and unit tests added.

Posted by Rob Allen (rob) on 2012-11-07T21:06:31.000+0000

This is a good idea, but the patch doesn't apply.

Posted by Frank Brückner (frosch) on 2012-11-08T17:08:17.000+0000

I will add a new patch. The current patch is very old.

Posted by Frank Brückner (frosch) on 2013-01-22T09:45:46.000+0000

Fixed on trunk (25238) and release-1.12 (25239)