ZF-8880: Zend_Validate_PostCode __construct method should have default $options = null

Issue Type:
Improvement
Created:
2010-01-20T03:40:34.000+0000
Last Updated:
2010-01-20T23:14:12.000+0000
Status:
Resolved
Fix version(s):
  • 1.10.0 (27/Jan/10)
Reporter:
Nick Pack (nickpack)
Assignee:
Thomas Weidner (thomas)
Tags:
  • Zend_Validate
Related issues:
Attachments:

Description

The construct method of Zend_Validate_PostCode is missing a default value for the $options parameter, seeing as it checks if (null === $options) I would suggest adding '= null' to the constructor so that nothing needs to be passed over if you intend to fetch the locale from the registry.

  • public function __construct($options)

    • public function __construct($options = null)

Comments

Posted by Martin de Keijzer (martin1982) on 2010-01-20T10:55:05.000+0000

I totally agree on this issue, in addition I have created a patch file.

Posted by Thomas Weidner (thomas) on 2010-01-20T23:14:11.000+0000

Fixed with r20458