ZF-9159: Zend_File_Transfer_Http::setOptions() fails to modify $_options if Zend_File_Transfer::_getFiles() returns an empty array

Issue Type:
Bug
Created:
2010-02-12T10:47:23.000+0000
Last Updated:
2010-02-25T07:49:10.000+0000
Status:
Resolved
Fix version(s):
  • 1.10.2 (24/Feb/10)
Reporter:
Noah Goodrich (gabriel1836)
Assignee:
Thomas Weidner (thomas)
Tags:
  • Zend_File_Transfer
Related issues:
Attachments:

Description

Zend_File_Transfer::setOptions() contains the following check:

$file = $this->_getFiles($files, false, true); // Always returns an array() even if it is empty.

if (is_array($options)) { if ($file === null) { // Because $file will always be an array, this can never execute. $this->_options = array_merge($this->_options, $options); }

// Code Continues....

Basically the check should be:

if(empty($file)) {

}

Comments

Posted by Thomas Weidner (thomas) on 2010-02-12T12:54:53.000+0000

Fixed with r21039