Zend Framework

remove 'final' attribute on Zend_Rest_Client methods

Details

  • Type: Improvement Improvement
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.10.2
  • Fix Version/s: 1.11.10
  • Component/s: Zend_Rest_Client
  • Labels:
    None

Description

Quite a lot of Zend_Rest_Client methods are final, which makes it impossible to subclass.

It's a real limitation for ZF as a framework not to be able to easily subclass Zend_Rest_Client.
It would be great if 'final' attribute got removed.

Strangely enough, Zend_Rest_Server has no final method. Am I missing something?

Enclosed is the diff realized against ZF 1.10.1

Regards,
Remy

  1. Client.php.diff
    03/Mar/10 3:45 PM
    0.6 kB
    Remy Damour
  2. Rest-Client.php.patch
    23/Jul/11 5:49 PM
    2 kB
    Bart McLeod
  3. Rest-Client.php.patch
    21/Jul/11 9:27 AM
    1 kB
    Bart McLeod

Activity

Hide
Remy Damour added a comment -

corresponding diff file against v1.10.1
simply remove all 'final ' statements

Show
Remy Damour added a comment - corresponding diff file against v1.10.1 simply remove all 'final ' statements
Hide
Bart McLeod added a comment - - edited

Added patch against trunk, likely also valid for 1.11 branch. This patch also fixes the issue that you can't sent data with a delete request.

Show
Bart McLeod added a comment - - edited Added patch against trunk, likely also valid for 1.11 branch. This patch also fixes the issue that you can't sent data with a delete request.
Hide
Bart McLeod added a comment -

New patch, I missed two final declarations in the original patch

Show
Bart McLeod added a comment - New patch, I missed two final declarations in the original patch
Hide
Bart McLeod added a comment -

Committed to trunk

Show
Bart McLeod added a comment - Committed to trunk

People

Vote (2)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved: