ZF-9510: Zend Oauth Client prepareOauth() do not take into account post parameters

Description

Hi,

On zend_oauth_client prepareOauth() does not take into account the POST parameters when using schema Zend_Oauth::REQUEST_SCHEME_QUERYSTRING

Issue is that on the server side I use the server provided by oauth http://code.google.com/p/oauth/… and it takes into account these parameters thus having bad signature.

A fix is to add the post params in the computed signature

        $params = array();
        if (!empty($this->paramsGet)) {
            $params = array_merge($params, $this->paramsGet);
            $query  = $this->getToken()->toQueryString(
                $this->getUri(true), $this->_config, $params
            );
        }
        if (!empty($this->paramsPost)) {
            $params = array_merge($params, $this->paramsPost);
            $query  = $this->getToken()->toQueryString(
                $this->getUri(true), $this->_config, $params
            );
        }

Comments

I'll need some time to check this out. My main concern is that if the ZF client works with other services, is the bug with ZF or with your server's implementation? I'll get back to you in a few days with a final comment on whether a fix will be needed or not.

Fixed in r22050. Can the reporter confirm the fix works as needed when possible? Thanks!