Zend Framework

Add Support for typeKey of Property

Details

  • Type: Improvement Improvement
  • Status: Resolved Resolved
  • Priority: Trivial Trivial
  • Resolution: Fixed
  • Affects Version/s: 1.10.3
  • Fix Version/s: 1.11.3
  • Component/s: Zend_View
  • Labels:
    None

Description

Current the headMeta helper only supports three typeKeys (name, http-equiv and charset) but it should include for a typeKey of property for the new facebook OpenGraph api (http://developers.facebook.com/docs/opengraph).

Attachments

  1. Text File
    zf9743.patch
    24/Apr/10 2:01 PM
    0.6 kB
    Jon Whitcraft
  2. Text File
    ZF-9743.patch
    03/Jan/11 1:13 AM
    11 kB
    Marc Hodgins

Issue Links

This issue is related to:
ZF-10796 Add XHTML1 RDFA doctype to Zend_View_Helper_Doctype Trivial Resolved

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jon Whitcraft added a comment -

See Attached Patch

Show
Jon Whitcraft added a comment - See Attached Patch
Hide
Permalink
Anton Visser added a comment -

This is becoming more and more important as web developers try to get better integration with social networks, so please could you push this up the priority order.

Show
Anton Visser added a comment - This is becoming more and more important as web developers try to get better integration with social networks, so please could you push this up the priority order.
Hide
Permalink
mayhem added a comment -

I agree with autor - thing is important enough to implement it

Show
mayhem added a comment - I agree with autor - thing is important enough to implement it
Hide
Permalink
Marc Hodgins added a comment -

Improved patch attached which includes unit tests, documentation, and adds full functionality similar to the 'meta' and 'http-equiv' meta tag properties – i.e. it is possible to do $this->headMeta()->setProperty('og:title', 'foo')

Show
Marc Hodgins added a comment - Improved patch attached which includes unit tests, documentation, and adds full functionality similar to the 'meta' and 'http-equiv' meta tag properties – i.e. it is possible to do $this->headMeta()->setProperty('og:title', 'foo')
Hide
Permalink
Marc Hodgins added a comment -

Applied to trunk in r23610, merged to 1.11 release branch in 23611.

Show
Marc Hodgins added a comment - Applied to trunk in r23610, merged to 1.11 release branch in 23611.
Hide
Permalink
mayhem added a comment -

I have test this patch and found that it requires setting XHTML1_RDFA doctype or using my own custom doctupe with "rdfa" string present on it. So if I use any other doctype, i can't set no Open Graph meta tags in document.

Official protocol specification http://ogp.me/ says nothing about doctype.

http://www.imdb.com/title/tt0117500/ don't use RDFa doctype
http://www.pravda.com.ua/news/2011/01/3/5746644/ don't use RDFa doctype

RDF documentation says that doctupe MAY be used instead of requisition.

http://www.w3.org/TR/2010/WD-xhtml-rdfa-20100803/

Documents written using the markup language defined in this specification can be validated using the DTD defined in Appendix B. If a document author wants to facilitate such validation, they may include the following declaration at the top of their document:

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML+RDFa 1.1//EN"
"http://www.w3.org/MarkUp/DTD/xhtml-rdfa-2.dtd">

{/quote}

This paragraph may be found also in HTML 4.01 RDFa specification

So I must use custom doctype with "rdfa" string inside instead of predefined constant.

I propose to remove doctype testing

Show
mayhem added a comment - I have test this patch and found that it requires setting XHTML1_RDFA doctype or using my own custom doctupe with "rdfa" string present on it. So if I use any other doctype, i can't set no Open Graph meta tags in document. Official protocol specification http://ogp.me/ says nothing about doctype. http://www.imdb.com/title/tt0117500/ don't use RDFa doctype http://www.pravda.com.ua/news/2011/01/3/5746644/ don't use RDFa doctype RDF documentation says that doctupe MAY be used instead of requisition. http://www.w3.org/TR/2010/WD-xhtml-rdfa-20100803/
Documents written using the markup language defined in this specification can be validated using the DTD defined in Appendix B. If a document author wants to facilitate such validation, they may include the following declaration at the top of their document: <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML+RDFa 1.1//EN" "http://www.w3.org/MarkUp/DTD/xhtml-rdfa-2.dtd"> {/quote} This paragraph may be found also in HTML 4.01 RDFa specification So I must use custom doctype with "rdfa" string inside instead of predefined constant. I propose to remove doctype testing
Hide
Permalink
Marc Hodgins added a comment -

@mayhem, I understand your concern. But, since "property" is not a supported attribute in non-RDFa Doctypes, using headMeta() to generate OGP meta tags without an RDFa doctype causes the document to fail validation. This seems wrong to me - to default to allowing the generation of HTML that won't validate. Just because other sites don't validate doesn't mean that is the correct way to do it.

There are a lot of "watchers" on this ticket - anyone else care to comment?

Show
Marc Hodgins added a comment - @mayhem, I understand your concern. But, since "property" is not a supported attribute in non-RDFa Doctypes, using headMeta() to generate OGP meta tags without an RDFa doctype causes the document to fail validation. This seems wrong to me - to default to allowing the generation of HTML that won't validate. Just because other sites don't validate doesn't mean that is the correct way to do it. There are a lot of "watchers" on this ticket - anyone else care to comment?
Hide
Permalink
mayhem added a comment -

nobody cares? ok, you convinced me to use XHTML_RDFA doctupe

Show
mayhem added a comment - nobody cares? ok, you convinced me to use XHTML_RDFA doctupe
Hide
Permalink
Pete Nystrom added a comment -

I still think things are off with the requirement of RDFa, and the validate function fails even if I do add the rdfa into the doctype declaration. My pages that have the following doctype:

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML+RDFa 1.1//EN"
"http://www.w3.org/MarkUp/DTD/xhtml-rdfa-2.dtd">

Still fail to pass:

// <meta property= ... /> is only supported with doctype RDFa
if (!$this->view->doctype()->isRdfa()
&& $item->type === 'property') { return false; }

If I comment out the return false the page loads fine with the correct og tags and the facebook share and like load perfectly. The og tags still work through facebook even if I don't change the doctype actually, so not sure why this is such a hard rule in the framework.

Thanks,
Pete

Show
Pete Nystrom added a comment - I still think things are off with the requirement of RDFa, and the validate function fails even if I do add the rdfa into the doctype declaration. My pages that have the following doctype: <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML+RDFa 1.1//EN" "http://www.w3.org/MarkUp/DTD/xhtml-rdfa-2.dtd"> Still fail to pass: // <meta property= ... /> is only supported with doctype RDFa if (!$this->view->doctype()->isRdfa() && $item->type === 'property') { return false; } If I comment out the return false the page loads fine with the correct og tags and the facebook share and like load perfectly. The og tags still work through facebook even if I don't change the doctype actually, so not sure why this is such a hard rule in the framework. Thanks, Pete
Hide
Permalink
Marc Hodgins added a comment -

@Pete, are you specifying the XHTML_RDFA doctype via the doctype view helper? See Example 21 here http://framework.zend.com/manual/en/zend.view.helpers.html

If you are manually setting the doctype (i.e. by hard-coding it in a view or layout instead of using the helper), the other view helpers (such as headMeta()) have no way to know that you have specified an RDFa-compatible doctype. So, the code in your example would be expected to return false. The framework does not know what doctype you are using unless you specify it with the doctype view helper.

It is a good idea to use the doctype helper to specify your doctype for reasons beyond this specific feature. For example, many view helpers (i.e. the form view helpers) check whether the doctype is specified as XHTML and adjust their output accordingly.

Show
Marc Hodgins added a comment - @Pete, are you specifying the XHTML_RDFA doctype via the doctype view helper? See Example 21 here http://framework.zend.com/manual/en/zend.view.helpers.html If you are manually setting the doctype (i.e. by hard-coding it in a view or layout instead of using the helper), the other view helpers (such as headMeta()) have no way to know that you have specified an RDFa-compatible doctype. So, the code in your example would be expected to return false. The framework does not know what doctype you are using unless you specify it with the doctype view helper. It is a good idea to use the doctype helper to specify your doctype for reasons beyond this specific feature. For example, many view helpers (i.e. the form view helpers) check whether the doctype is specified as XHTML and adjust their output accordingly.

People

Vote (10)
Watch (9)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Zend Framework. Try JIRA - bug tracking software for your team.