[#ZF-9889] Wrong test for exists locale - Zend Framework Issue Tracker

Details

Type: Bug
Status: Resolved
Priority: Major
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 1.10.6
Component/s: Zend_Locale
Labels:
None

Description

Hi,
i have problem with commit #22278. After this commit is generated WARNING:

Warning: array_key_exists() [<a href='function.array-key-exists'>function.array-key-exists</a>]: The first argument should be either a string or an integer in /home/lestr/projekty/alarm-online/trunk/library/Zend/Locale.php on line 811

I think there is missing negation before calling is_array function.

This is svn diff from my local copy of releace branche

 
--- library/Zend/Locale.php     (revision 329)
+++ library/Zend/Locale.php     (working copy)
@@ -808,7 +808,7 @@
     public static function isLocale($locale, $strict = false, $compatible = true)
     {
         if (($locale instanceof Zend_Locale) 
-            || (is_array($locale) && array_key_exists($locale, self::$_localeData))
+            || (!is_array($locale) && array_key_exists($locale, self::$_localeData))
         ) {
             return true;
         }

Is this fix correct?

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Mickael Perraud added a comment - 27/May/10 2:00 AM

I don't know if it's the correct fix but I can confirm that there is a bug.

I think that should be:

public static function isLocale($locale, $strict = false, $compatible = true)
     {
         if (($locale instanceof Zend_Locale) 
-            || (is_array($locale) && array_key_exists($locale, self::$_localeData))
+            || (is_string($locale) && array_key_exists($locale, self::$_localeData))
         ) {
             return true;
         }

Show

Mickael Perraud added a comment - 27/May/10 2:00 AM I don't know if it's the correct fix but I can confirm that there is a bug. I think that should be:

public static function isLocale($locale, $strict = false, $compatible = true)
     {
         if (($locale instanceof Zend_Locale) 
-            || (is_array($locale) && array_key_exists($locale, self::$_localeData))
+            || (is_string($locale) && array_key_exists($locale, self::$_localeData))
         ) {
             return true;
         }

Hide

Permalink

Thomas Weidner added a comment - 27/May/10 2:27 PM

Fixed by r22314

Show

Thomas Weidner added a comment - 27/May/10 2:27 PM Fixed by r22314

People

Assignee:

Thomas Weidner

Reporter:

Lukas Drbal

Vote (0)

Watch (2)

Dates

Created:

26/May/10 2:00 AM

Updated:

27/May/10 2:27 PM

Resolved:

27/May/10 2:27 PM