[#ZF-9926] Incorrect html output produced by ajaxLink - Zend Framework Issue Tracker

Details

Type: Patch
Status: Resolved
Priority: Critical
Resolution: Fixed
Affects Version/s: 1.10.5
Fix Version/s: 1.11.8
Component/s: ZendX_JQuery
Labels:
- zf-crteam-padraic
- zf-crteam-priority

Description

When 'inline' key are used - html output is incorrect!

This code:

<?php echo $this->ajaxLink(
  '[Delete]',
  $this->url(array('action' => 'delete', 'id' => $entry->id)),
  array(
    'dataType'   => 'json',
    'noscript'   => true,
    'beforeSend' => 'if(!confirm("Do you really want to delete this item?")) {return false;}$("#progress-bar").show();',
    'complete'    => '$("#progress-bar").hide();$("#entry-' . $entry->id . '").hide("slow");',
    'inline'   => true
  ),
  array('format' => 'json')
) ?>

produces:

<a href="/index/delete/id/57" onclick='if(!confirm("Do you really want to delete this item?")) {return false;}$("#progress-bar").show();$.post('/index/delete/id/57', {format:"json"}, function(data, textStatus) { $("#progress-bar").hide();$("#entry-57").hide("slow"); }, 'json');return false;'>[Delete]</a>

Just replace this code in AjaxLink.php:

switch($requestHandler) {
            case 'GET':
                $js[] = sprintf("%s.get('%s', %s, function(data, textStatus) { %s }, '%s');return false;",
                    $jqHandler, $url, $params, implode(" ", $callbackCompleteJs), $options['dataType']);
                break;
            case 'POST':
                $js[] = sprintf("%s.post('%s', %s, function(data, textStatus) { %s }, '%s');return false;",
                    $jqHandler, $url, $params, implode(" ", $callbackCompleteJs), $options['dataType']);
                break;
        }

on this (it solves the problem):

switch($requestHandler) {
            case 'GET':
                $js[] = sprintf("%s.get(\"%s\", %s, function(data, textStatus) { %s }, \"%s\");return false;",
                    $jqHandler, $url, $params, implode(" ", $callbackCompleteJs), $options['dataType']);
                break;
            case 'POST':
                $js[] = sprintf("%s.post(\"%s\", %s, function(data, textStatus) { %s }, \"%s\");return false;",
                    $jqHandler, $url, $params, implode(" ", $callbackCompleteJs), $options['dataType']);
                break;
        }

More Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

AjaxLink.php.patch

24/Apr/11 12:43 PM

1 kB

Kim Blomqvist
AjaxLinkTest.php.patch

24/Apr/11 12:43 PM

1 kB

Kim Blomqvist
ZF-9926-rev2.patch

15/Jul/11 4:40 PM

12 kB

Kim Blomqvist
ZF-9926-rev3.patch

23/Jul/11 11:59 AM

11 kB

Kim Blomqvist

Issue Links

This issue depends on:
ZF-11597	Properly escape event attribute values in HtmlElement view helper

This issue is related to:
ZF-11597	Properly escape event attribute values in HtmlElement view helper

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Kien added a comment - 28/Feb/11 11:41 PM

I have the same problem like in this article "http://zend-framework-community.634137.n4.nabble.com/jQuery-Ajax-link-inside-container-how-to-make-this-td663656.html"
my ajax link does not work inside container (called by another ajaxlink). Could someone help me?

Show

Kien added a comment - 28/Feb/11 11:41 PM I have the same problem like in this article "http://zend-framework-community.634137.n4.nabble.com/jQuery-Ajax-link-inside-container-how-to-make-this-td663656.html" my ajax link does not work inside container (called by another ajaxlink). Could someone help me?

Hide

Permalink

Kim Blomqvist added a comment - 24/Apr/11 12:43 PM

Patch attached.

Show

Kim Blomqvist added a comment - 24/Apr/11 12:43 PM Patch attached.

Hide

Permalink

Matthew Weier O'Phinney added a comment - 05/Jul/11 3:03 PM

Patch reviewed and applied to both trunk and 1.11 release branch.

Show

Matthew Weier O'Phinney added a comment - 05/Jul/11 3:03 PM Patch reviewed and applied to both trunk and 1.11 release branch.

Hide

Permalink

Jakob Schumann added a comment - 15/Jul/11 11:55 AM - edited

This patch breaks it for me (Using ZF 1.11.9 for ZF + ZendX):

HTML generated by ajaxLink with this patch:

<a href="#" title="edit" onclick='$.get("/translation/index/edit/id/2839", {}, function(data, textStatus) { $('#translation_2839').html(data); }, "html");return false;'

Which gets interpreted in FF5 as:

<a false;'="" "html");return="" },="" #translation_2777').html(data);="" onclick="$.get(&quot;/translation/index/edit/id/2777&quot;, {}, function(data, textStatus) { $(" title="edit" href="#">

The quotes aren't properly escaped.

The old version generated:

<a onclick="$.get('/translation/index/edit/id/2818', {}, function(data, textStatus) { $('#translation_2818').html(data); }, 'html');return false;" title="edit" href="#">

unchanged view script code used for both versions:

echo $this->ajaxLink(
                            $str,
                            BASE_URL."translation/index/edit/id/".$id,
                            array(
                                'update' => '#translation_'.$id,
                                'inline' => true,
                                'title' => 'edit',
                            )
                        );

Show

Jakob Schumann added a comment - 15/Jul/11 11:55 AM - edited This patch breaks it for me (Using ZF 1.11.9 for ZF + ZendX): HTML generated by ajaxLink with this patch:

<a href="#" title="edit" onclick='$.get("/translation/index/edit/id/2839", {}, function(data, textStatus) { $('#translation_2839').html(data); }, "html");return false;'

Which gets interpreted in FF5 as:

<a false;'="" "html");return="" },="" #translation_2777').html(data);="" onclick="$.get(&quot;/translation/index/edit/id/2777&quot;, {}, function(data, textStatus) { $(" title="edit" href="#">

The quotes aren't properly escaped. The old version generated:

<a onclick="$.get('/translation/index/edit/id/2818', {}, function(data, textStatus) { $('#translation_2818').html(data); }, 'html');return false;" title="edit" href="#">

unchanged view script code used for both versions:

echo $this->ajaxLink(
                            $str,
                            BASE_URL."translation/index/edit/id/".$id,
                            array(
                                'update' => '#translation_'.$id,
                                'inline' => true,
                                'title' => 'edit',
                            )
                        );

Hide

Permalink

Jakob Schumann added a comment - 15/Jul/11 11:59 AM

Applied patch breaks HTML for generated JS code with nested quotes

Show

Jakob Schumann added a comment - 15/Jul/11 11:59 AM Applied patch breaks HTML for generated JS code with nested quotes

Hide

Permalink

Kim Blomqvist added a comment - 15/Jul/11 1:17 PM

Applied patch breaks HTML for generated JS code with nested quotes

Jakob - I will look into this

Show

Kim Blomqvist added a comment - 15/Jul/11 1:17 PM

Applied patch breaks HTML for generated JS code with nested quotes

Jakob - I will look into this

Hide

Permalink

Kim Blomqvist added a comment - 15/Jul/11 4:40 PM

Patch rev2 attached. Jakob, could you please test?

Show

Kim Blomqvist added a comment - 15/Jul/11 4:40 PM Patch rev2 attached. Jakob, could you please test?

Hide

Permalink

Jakob Schumann added a comment - 20/Jul/11 9:20 AM

With the patch rev2 it works, output for my testcase is:

<a href="#" title="edit" onclick='$.get("/translation/index/edit/id/2818", {}, function(data, textStatus) { $("#translation_2818").html(data); }, "html");return false;'>

Looks good, thanks, hope for an update soon, the monthly bug hunt shouldn't be far away

Show

Jakob Schumann added a comment - 20/Jul/11 9:20 AM With the patch rev2 it works, output for my testcase is:

<a href="#" title="edit" onclick='$.get("/translation/index/edit/id/2818", {}, function(data, textStatus) { $("#translation_2818").html(data); }, "html");return false;'>

Looks good, thanks, hope for an update soon, the monthly bug hunt shouldn't be far away

Hide

Permalink

Kim Blomqvist added a comment - 23/Jul/11 11:59 AM - edited

I noticed that HtlmElement view helper had some quote handling for event attributes. Unfortunately it didn't do the job. Although the revision 2 of the patch included here works for Jakob now, similar issues may occur in future. Thus I have made a new revision of this patch. The new revision depends on ~~ZF-11597~~.

Show

Kim Blomqvist added a comment - 23/Jul/11 11:59 AM - edited I noticed that HtlmElement view helper had some quote handling for event attributes. Unfortunately it didn't do the job. Although the revision 2 of the patch included here works for Jakob now, similar issues may occur in future. Thus I have made a new revision of this patch. The new revision depends on ~~ZF-11597~~.

Hide

Permalink

Pádraic Brady added a comment - 26/Aug/11 9:13 AM

Patch applied in r24400

Show

Pádraic Brady added a comment - 26/Aug/11 9:13 AM Patch applied in r24400

People

Assignee:

Kim Blomqvist

Reporter:

Dmitry A Ponomarev

Vote (0)

Watch (2)

Dates

Created:

01/Jun/10 9:02 AM

Updated:

26/Aug/11 9:13 AM

Resolved:

26/Aug/11 9:13 AM