[#ZF-9941] Zend_Currency::toCurrency() options - Zend Framework Issue Tracker

Details

Type: Bug
Status: Resolved
Priority: Minor
Resolution: Fixed
Affects Version/s: 1.10.5
Fix Version/s: 1.10.6
Component/s: Zend_Currency
Labels:
None

Description

I think there is a bug in Zend/Currency.php, Line: 140:

if (is_array($value) && isset($options['value'])) {

.. which should be :

if (isset($options['value'])) {

.. because if variable $value is strictly null it will never by an array and 'value' from the options array will be skipped and the one from $this->_options will be used.

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Thomas Weidner added a comment - 03/Jun/10 4:45 AM

The framework code works like expected.
Please give some reproduceable code for the problem you have.

Show

Thomas Weidner added a comment - 03/Jun/10 4:45 AM The framework code works like expected. Please give some reproduceable code for the problem you have.

Hide

Permalink

Aurimas Likas added a comment - 03/Jun/10 5:42 AM

$currency = new Zend_Currency(
array(
'value' => 1000,
)
);

echo $currency->toCurrency(null, array('value' => 2000)); // 1000

I think it should return 2000. Though if it is expected behavior the statement in Line #139 remains pointless:

if ($value === null) {
if (is_array($value) && isset($options['value'])) {

because null !== array()

Show

Aurimas Likas added a comment - 03/Jun/10 5:42 AM $currency = new Zend_Currency( array( 'value' => 1000, ) ); echo $currency->toCurrency(null, array('value' => 2000)); // 1000 I think it should return 2000. Though if it is expected behavior the statement in Line #139 remains pointless: if ($value === null) { if (is_array($value) && isset($options['value'])) { because null !== array()

Hide

Permalink

Thomas Weidner added a comment - 04/Jun/10 7:56 AM

Fixed with r22369

Show

Thomas Weidner added a comment - 04/Jun/10 7:56 AM Fixed with r22369

People

Assignee:

Thomas Weidner

Reporter:

Aurimas Likas

Vote (0)

Watch (1)

Dates

Created:

03/Jun/10 4:36 AM

Updated:

04/Jun/10 7:56 AM

Resolved:

04/Jun/10 7:56 AM