[#ZF-9944] Zend_Form_Element_File loses breakChainOnFailure option if NotEmpty validator is not supplied - Zend Framework Issue Tracker

Details

Type: Bug
Status: Resolved
Priority: Minor
Resolution: Fixed
Affects Version/s: 1.10.5
Fix Version/s: 1.10.6
Component/s: Zend_Form, Zend_Validate, Zend_Validate_File
Labels:
None

Description

If I create a file upload form element with several validators, setting $breakChainOnFailure for each of them, the chain doesn't break and several error messages are shown.

I've spent hours to find the reason and I've found it. This is the faulty part of Zend_Form_Element_File::isValid()'s body:

if (!$this->isRequired()) {
    $adapter->setOptions(array('ignoreNoFile' => true), $this->getName());
} else {
    $adapter->setOptions(array('ignoreNoFile' => false), $this->getName());
    if ($this->autoInsertNotEmptyValidator() and
           !$this->getValidator('NotEmpty'))
    {
        $validators = $this->getValidators();
        $notEmpty   = array('validator' => 'NotEmpty', 'breakChainOnFailure' => true);
        array_unshift($validators, $notEmpty);
        $this->setValidators($validators);
    }
}

As you can see, this code checks if the element is set to be required and if it is and NotEmpty validator is not supplied, it gets all already set validators, adds NotEmpty to them, and sets them back. Unfortunately is loses $breakChainOnFailure option of all those previously set validators during this process.

The temporary workaround to this bug is to explicitly add NotEmpty validator to the element.

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Christian Albrecht added a comment - 03/Jun/10 10:14 AM

Sorry i cannot reproduce this in current trunk and 1.10 release branch with the following setup:

public function testAction() {                                                                                                                           
         $form = new Zend_Form();
         $form->addElement('file',
                           'avatar',
                           array('label' => 'Avatar',
                                 'description' => 'Avatar Description',
                                 'required' => true,
                                 'validators' => array(array('Extension',
                                                             true,
                                                             array(false,
                                                                   'png,jpg,jpeg,gif',
                                                                   'messages' => array('fileExtensionFalse' => 'Wrong File Extension'))),
                                                       array('Size',
                                                             true,
                                                             array('max' => 5242880,
                                                                   'messages' => array('fileSizeTooBig' => 'Filesize too big'))))));
         $form->addElement('submit','submit');

         if ($this->getRequest()->isPost()) {
             $form->isValid($this->getRequest()->getParams());
         }
         die($form->render());
     }

Could you provide a simple Testcase that does fail for you?

Show

Christian Albrecht added a comment - 03/Jun/10 10:14 AM Sorry i cannot reproduce this in current trunk and 1.10 release branch with the following setup:

public function testAction() {                                                                                                                           
         $form = new Zend_Form();
         $form->addElement('file',
                           'avatar',
                           array('label' => 'Avatar',
                                 'description' => 'Avatar Description',
                                 'required' => true,
                                 'validators' => array(array('Extension',
                                                             true,
                                                             array(false,
                                                                   'png,jpg,jpeg,gif',
                                                                   'messages' => array('fileExtensionFalse' => 'Wrong File Extension'))),
                                                       array('Size',
                                                             true,
                                                             array('max' => 5242880,
                                                                   'messages' => array('fileSizeTooBig' => 'Filesize too big'))))));
         $form->addElement('submit','submit');

         if ($this->getRequest()->isPost()) {
             $form->isValid($this->getRequest()->getParams());
         }
         die($form->render());
     }

Could you provide a simple Testcase that does fail for you?

Hide

Permalink

Elnur Abdurrakhimov added a comment - 03/Jun/10 11:54 AM

This is the simplified version of my form which is enough to reproduce the bug:

class Form_User_Avatar extends Zend_Form
{
    public function init()
    {
        $this->addElement('file', 'avatar', array(
            'label' => 'Avatar',
            'required' => true,
            'validators' => array(
                array('Extension', true, array(
                    false,
                    'png,jpg,jpeg,gif'
                )),
                array('Size', true, array(
                    'max' => 5242880
                ))
            )
        ));

        $this->addElement('submit', 'submit');
    }
}

Try to upload a file which is larger than the size limit of this form (5M) but is smaller than post_max_size (in my case it's 8M).

Show

Elnur Abdurrakhimov added a comment - 03/Jun/10 11:54 AM This is the simplified version of my form which is enough to reproduce the bug:

class Form_User_Avatar extends Zend_Form
{
    public function init()
    {
        $this->addElement('file', 'avatar', array(
            'label' => 'Avatar',
            'required' => true,
            'validators' => array(
                array('Extension', true, array(
                    false,
                    'png,jpg,jpeg,gif'
                )),
                array('Size', true, array(
                    'max' => 5242880
                ))
            )
        ));

        $this->addElement('submit', 'submit');
    }
}

Try to upload a file which is larger than the size limit of this form (5M) but is smaller than post_max_size (in my case it's 8M).

Hide

Permalink

Christian Albrecht added a comment - 03/Jun/10 12:56 PM

Assigning to Thomas and updating Components

Show

Christian Albrecht added a comment - 03/Jun/10 12:56 PM Assigning to Thomas and updating Components

Hide

Permalink

Thomas Weidner added a comment - 04/Jun/10 1:20 PM

New feature implemented with r22372

Show

Thomas Weidner added a comment - 04/Jun/10 1:20 PM New feature implemented with r22372

People

Assignee:

Thomas Weidner

Reporter:

Elnur Abdurrakhimov

Vote (0)

Watch (0)

Dates

Created:

03/Jun/10 7:30 AM

Updated:

04/Jun/10 1:20 PM

Resolved:

04/Jun/10 1:20 PM