Zend Framework

uienable and/or ui_enable in ZendX_Application_Resource_JQuery buggy

Details

Description

Hello!
There is a problem in the JQuery Resource Plugin:

ZendX/Application/Resource/JQuery.php — line 158 - 160
if ((isset($key['uienable']) && (bool) $key['uienable'])
            || (isset($key['ui_enable']) && (bool) $key['ui_enable'])
            || (!isset($key['ui_enable']) && !isset($key['uienable'])))
       {
          ...

the variable $key is used in the foreach-loop before:

ZendX/Application/Resource/JQuery.php — line 109
foreach ($options as $key => $value) {
...

$key should be replaced by $options:

ZendX/Application/Resource/JQuery.php — line 158 - 160
if ((isset($options['uienable']) && (bool) $options['uienable'])
            || (isset($options['ui_enable']) && (bool) $options['ui_enable'])
            || (!isset($options['ui_enable']) && !isset($options['uienable'])))
        {
            $this->_view->JQuery()->uiEnable();
        } else {
            $this->_view->JQuery()->uiDisable();
        }

best regards,
rené kerner

Issue Links

Activity

Hide
René Kerner added a comment -

push

Show
René Kerner added a comment - push
Hide
Dolf Schimmel (Freeaqingme) added a comment -

What configuration are you trying to do? What is the outcome? And what is the expected outcome?

Show
Dolf Schimmel (Freeaqingme) added a comment - What configuration are you trying to do? What is the outcome? And what is the expected outcome?
Hide
René Kerner added a comment -

i don't like to repeat myself... but if it is really necessary:

as described above and in the issue title, the JQuery resource plugin doesn't parse application.ini / config-options for uienable/ui_enable correct because it's not read from the $options variable, but from the $key variable, which only exists in the foreach-loop-block.

Show
René Kerner added a comment - i don't like to repeat myself... but if it is really necessary: as described above and in the issue title, the JQuery resource plugin doesn't parse application.ini / config-options for uienable/ui_enable correct because it's not read from the $options variable, but from the $key variable, which only exists in the foreach-loop-block.
Hide
René Kerner added a comment -

application.ini:
resources.jquery.uienable = 0

jquery ui should be disabled.

but it's not disabled by the zend application resource plugin.

Show
René Kerner added a comment - application.ini: resources.jquery.uienable = 0 jquery ui should be disabled. but it's not disabled by the zend application resource plugin.
Hide
René Kerner added a comment -

push

Show
René Kerner added a comment - push
Hide
René Kerner added a comment -

push

Show
René Kerner added a comment - push
Hide
René Kerner added a comment -

push

Haaaallooooooo???
Ist da draussen irgendwer????

Kümmert sich da mal jemand drum???

Show
René Kerner added a comment - push Haaaallooooooo??? Ist da draussen irgendwer???? Kümmert sich da mal jemand drum???
Hide
René Kerner added a comment -

push

sorry I missed, that i had to write in english...
possibly... because it's quite sunny and hot in germany...

I said:

heeeellloooooooooooo?
somebody out there?

could somebody react on that issue?

Show
René Kerner added a comment - push sorry I missed, that i had to write in english... possibly... because it's quite sunny and hot in germany... I said: heeeellloooooooooooo? somebody out there? could somebody react on that issue?
Hide
Dolf Schimmel (Freeaqingme) added a comment -

Aber naturlich kan ich das

Pushing usually doesn't work. ZF is mainly maintained by volunteers, and as such, they sometimes do have time, and sometimes they don't.

Show
Dolf Schimmel (Freeaqingme) added a comment - Aber naturlich kan ich das Pushing usually doesn't work. ZF is mainly maintained by volunteers, and as such, they sometimes do have time, and sometimes they don't.
Hide
René Kerner added a comment -

I know. But I published that issue more than 2 weeks ago and it was a very simple bug.
And there was no reaction until
AND I also submitted the patch for this bug, directly with the issue.

Show
René Kerner added a comment - I know. But I published that issue more than 2 weeks ago and it was a very simple bug. And there was no reaction until AND I also submitted the patch for this bug, directly with the issue.
Hide
Dolf Schimmel (Freeaqingme) added a comment -

the point is; there are a lot of small bugs known in the issue tracker. In any way; the issue has been resolved in trunk, and was merged with the 1.10 release branch. Meaning that it will be released in the next mini release.

Show
Dolf Schimmel (Freeaqingme) added a comment - the point is; there are a lot of small bugs known in the issue tracker. In any way; the issue has been resolved in trunk, and was merged with the 1.10 release branch. Meaning that it will be released in the next mini release.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: