ZF2-219: Should be using associative arrays for joins in Zend\Db\Sql\Select.php

Issue Type:
Improvement
Created:
2012-03-13T16:56:49.000+0000
Last Updated:
2012-05-11T17:31:04.000+0000
Status:
Resolved
Fix version(s):
    Reporter:
    Guillaume Métayer (willy0275)
    Assignee:
    Ralph Schindler (ralph)
    Tags:
    • Zend\Db
    • Zend_Db
    Related issues:
    Attachments:

    Description

    On line 24 of Zend\Db\Sql\Select.php, the join is added with "$this->joins[] = array($name, $on, $columns, $type);", which then requires using $join[3] etc later on. I suggest we use associative arrays here for code clarity.

    Comments

    Posted by Ralph Schindler (ralph) on 2012-03-13T22:39:39.000+0000

    I could go with that.

    Posted by Ralph Schindler (ralph) on 2012-05-11T17:31:04.000+0000

    Refactored in master.