ZF2-311: Zend\Filter tests failed

Issue Type:
Bug
Created:
2012-05-23T03:35:31.000+0000
Last Updated:
2012-06-06T11:16:39.000+0000
Status:
Resolved
Fix version(s):
    Reporter:
    simon liu (simonliu)
    Assignee:
    Maks 3w (maks3w)
    Tags:
    • Zend\Filter
    Related issues:
    Attachments:

    Description

    Zend\Filter\Compress\Tar::decompress() return boolean, and it can not return other stuff, so the assert always fails:

    
$content = $filter->decompress($content);
$this->assertEquals(dirname(__DIR__) . DIRECTORY_SEPARATOR . '_files' . DIRECTORY_SEPARATOR, $content);

    Comments

    Posted by simon liu (simonliu) on 2012-05-23T03:40:40.000+0000

    https://github.com/zendframework/zf2/pull/1334

    Posted by Maks 3w (maks3w) on 2012-05-23T15:05:04.000+0000

    I have open the story #53 in AgileZen to register the need of refactor this component.

    The story is actually in the backlog waiting for a RFC.

    Posted by Evan Coury (evan.pro) on 2012-05-26T23:51:43.000+0000

    I have updated the Tar::decompress() method to at least return the value expected by the test and the CompressionAlgorithmInterface. At least we can have a passing build in the meantime pending story #53 without having to mark a test as skipped.

    https://github.com/zendframework/zf2/pull/1379

    Posted by Maks 3w (maks3w) on 2012-06-06T11:16:38.000+0000

    The code to test has been fixed and the rest of the tasks will be updated in the mentioned story.