<p>I noticed from the use cases that the names of convenience methods appear to be indeterministic. For example, a log message of <code>Zend_Log::CRITICAL</code> would correspond to an invocation of <code>Zend_Log::crit()</code>. Does this matter? User-defined log levels, however, appear to result in method names matching the level name (e.g., "foo").</p>

<p>I'm not sure I fully understand the first sentence of UC-04; perhaps a slight rephrasing would help?</p>

<p>How would I create a logger that writes messages only of a user-defined log level? For instance, let's assume that I want to write only "specialError" level messages both to a log file and to an e-mail address. Would this use case be considered in the scope of the proposal?</p>

<p>It might be reasonable to use Zend_Log for application security auditing. For example, it is often valuable to collect information about certain security violations, such as logging when users attempt to perform unauthorized operations. I could imagine providing via the Zend_Auth and Zend_Acl APIs methods to plug in Zend_Log objects for providing for an audit trail.</p>

<p>The proposal is shaping up nicely, and the approach of using use cases and test-driven development seems very appropriate to me.</p>

<p>I'd like to see two additional things: (1) The constructor should take a single argument, a log adapter; this would be more convenient, and ensure no logging happens prior to logging a message. (2) I like the logLevel(), but want to make sure that the convenience methods would not change the global log level (I assume they wouldn't, but feel this should be explicit criteria).</p>

<ac:macro ac:name="note"><ac:parameter ac:name="title">Official Zend comment</ac:parameter><ac:rich-text-body>
<p>We have reviewed this proposal and we approve it for inclusion in the Zend Framework.</p>

<p>This represents a redesign of the existing Zend_Log class, and it is the intention to remove the old implementation in favor of this new design.</p>

<p>We have a few specific comments that we would like to see addressed in the design:</p>
<ul>
<li>We anticipate that in most cases, only one log writer would be needed. Can a single writer object be specified in the Zend_Log() constructor? This would be equivalent to adding the first writer after instantiating the Zend_Log object, but it would just make the code one line shorter.</li>
<li>It seems to make sense that there should be at least one writer, or else any messages written will go nowhere. With the current design it is possible to send messages to a Zend_Log object before adding any writers to it. What happens in this case? Is it reasonable to require at least one writer be registered, and if none are registered, the logging methods throw an exception? Or is there a legitimate use case for writing a message while having no writers registered?</li>
<li>There should be either an interface or an abstract class defined for filters, so that users know how to write their own. Also, we had wished we could see what a custom filter implementation would look like, but we understand why the class skeletons are omitted from this proposal.</li>
<li>We understand that it's traditional log4j-like functionality for filtering to restrict output to a given log level or lower level. How would one restrict output to one specific log level (other than level 0)? Can this be done with a custom filter object?</li>
</ul>
</ac:rich-text-body></ac:macro>

<p>Hi. I have a feature request. I have actually stumbled upon it while replying to Gavin's comment concerning my own proposal:
<a class="external-link" href="http://framework.zend.com/wiki/display/ZFPROP/Zend_Controller_Router_RegexRoute+-+Michael+Minicki">http://framework.zend.com/wiki/display/ZFPROP/Zend_Controller_Router_RegexRoute+-+Michael+Minicki</a></p>

<p>In RewriteRouter I need to log a couple of messages or a pack of data at once:</p>

<ac:macro ac:name="code"><ac:plain-text-body><![CDATA[
if ($this->_log) {
$message = 'Type: ' . get_class($route) . '; ' .
'Route: ' . $route->getMatchString() . '; ' .
'Path: ' . $path . '; ' .
'Result: ' . $result;
$this->_log->debug($message);
}
]]></ac:plain-text-body></ac:macro>

<p>It gave me an idea to pass the message as an array:</p>

<ac:macro ac:name="code"><ac:plain-text-body><![CDATA[
$message = array(
'Type' => get_class($route),
'Route' => $route->getMatchString(),
'Path' => $path,
'Result' => $result
);
$this->_log->debug($message);
]]></ac:plain-text-body></ac:macro>

<p>Which can then be rendered differently by different writers. </p>

<p>For example, XML writer can render it as:</p>

<ac:macro ac:name="code"><ac:plain-text-body><![CDATA[
<LogItem>
<Type>Zend_Controller_Router_Route</Type>
<Route>:action/:year</Route>
<Path>users/martel</Path>
<Result>false</result>
</LogItem>
]]></ac:plain-text-body></ac:macro>

<p>While file writer could use multiline entry:</p>

<ac:macro ac:name="code"><ac:plain-text-body><![CDATA[
2006-02-03 16:54 Debug:
\t Type: Zend_Controller_Router_Route
\t Route: :action/:year
\t Path: users/martel
\t Result: false
]]></ac:plain-text-body></ac:macro>

<p>And DB of course can keep it on one line separated with semicolon.</p>

<p>Hope you will like it too <ac:emoticon ac:name="wink" /></p>

<p>How about setting log format?</p>

<p>for example:<br />
$log->setFormat("%datetime <ac:link><ri:page ri:content-title="%pid" /></ac:link> %level %message");</p>

<p>by doing:<br />
$log->warning("Live support not ready");</p>

<p>should produce:<br />
2007-03-12 14:11:38 <ac:link><ri:page ri:content-title="8439" /></ac:link> WARNING Live support not ready</p>

<p>There should be predefined keyword for formatting, <br />
the most important IMHO:</p>

<p>datetime, current locale date time<br />
date,<br />
time,<br />
pid, current process ID<br />
level, current log level<br />
message, log message</p>

<p>Thanks</p>

<p>Is there an existing proposal to contribute a rotating log file writer?</p>

<p>If yes, could someone kindly point me to it?</p>