<p>Some of my thoughts on this</p>
<ul>
<li>I think it could take third parameter $iec like
<ac:macro ac:name="code"><ac:plain-text-body><![CDATA[
public function fileSize($filesize, $precision = 3, $iec = false)
]]></ac:plain-text-body></ac:macro>
When $iec is true this would produce KiB instead of KB, MiB instead of MB and so on.<br />
These are IEC standard binary prefixes that were introduced to prevent confusion with SI prefixes.<br />
SI states that kilo is 1000 and mega is 1000000 and these are also used in computer industry for hard disk capacity on customer boxes whilst Windows uses it in differnt meaning. Certainly there is a confusion. I think including binary prefixes an an option would be good addition as they are widespread in some communities and even some companies embraced it.</li>
</ul>

<p> For further information please see <a class="external-link" href="http://en.wikipedia.org/wiki/Binary_prefix#IEC_standard_prefixes">http://en.wikipedia.org/wiki/Binary_prefix#IEC_standard_prefixes</a>.</p>

<ul>
<li>I think that it would be also useful to include a possibility to pass string path like fileSize("/home/user/file") on Unices and fileSize("C:\\x
y<br class="atl-forced-newline" />z") on Windows boxes or even Zend_Uri instances beginning with file:// to this and make this automatically read apropriate info from filesystem and display in user friendly manner</li>
</ul>

<p>This is a much needed addition IMO.</p>

<p>It'd be useful to be able to specify which unit that should be used. This would make possible, for example, displaying a list of files with all sizes in MB even if some files are >1GB or <1MB for visual consistency.</p>

<p>I also noticed you do divide stuff inside your helper. I think you could reuse Zend_Measure_Binary as it already supports both SI and IEC.</p>

<p>Marthin, Zend_Measure_Binary has corresponding <span style="text-decoration: line-through;">bi</span> IEC suffixes<br />
eg MEGABYTE -> MEBIBYTE<br />
and looking at code now I would say it uses base 10 SI now not IEC <ac:emoticon ac:name="wink" /><br />
well actually it would be useful to have three state ('traditional', 'si', 'iec')<br />
and have $norm parameter instead of $iec taking one of these strings.</p>

<p>traditional <ac:link><ri:page ri:content-title="KILOBYTE..." /></ac:link> would mean base 2 and KB (^10), MB (^20), GB (^30)| si <ac:link><ri:page ri:content-title="KILOBYTE_SI..." /></ac:link> meaning base 10 and KB (^3) MB | iec <ac:link><ri:page ri:content-title="KIBIBYTE..." /></ac:link> meaning base 2 KiB (^10) MiB (^20) and GiB (^30)</p>

<p>and also I would like to see is_string($fileSize) -> stat FS and get info out of there</p>

<p>Looks nice, but what about possibility of passing a string as first parameter that would be interpreted as file path to read file size from file system?</p>

<p>This could be sth like</p>

<ac:macro ac:name="code"><ac:plain-text-body><![CDATA[
if(is_string($fileSize))
{
if(!file_exists($fileSize))

$fileSize = filesize($fileSize);
}
]]></ac:plain-text-body></ac:macro>

<p>Within your code you use Zend_Measure_Binary.<br />
Nice to see that my component is reused <ac:emoticon ac:name="smile" /><br />
But you miss some things:</p>

<p>1.) When you use a other component you must also write this within your proposal, section 4 dependencies.</p>

<p>2.) Zend_Measure_Binary allows also to use localized input. Which means it would recognise "1,000.00" in german as "1 000,00" in french or "1.000,00" in english. You should also support this possibility when using Zend_Measure. Therefor you must integrate a locale (getLocale/setLocale) or/and use a generalised Zend_Locale instance from registry when available. This way all components which are localizable use the same locale.</p>

<p>3.) Zend_Measure_Binary COULD convert from/to for you. You stated that this component will not do this within your initial description. The possibility is available through Zend_Measure_Binary.</p>

<p>Greetings<br />
Thomas</p>

<p>I have refactored it not to use any Locale component except Zend_Measure_Binary, which is essentially important</p>

<ac:macro ac:name="note"><ac:parameter ac:name="title">Zend Official Response</ac:parameter><ac:rich-text-body>
<p>This has been accepted to Zend Laboratory.</p>

<p>There are few concerns we would like to see worked out:</p>
<ul>
<li>Currently, there is a hidden dependency on Zend_Locale. By using Zend_Measure,<br />
Zend_Locale is included into the mix, thus, by using this seemingly simple view helper,<br />
one would be building out a Zend_Locale environment automagically which could cause some<br />
performance degradation in applications. Ideally, using Zend_Measure and Zend_Locale would be<br />
an opt-in feature to keep this lightweight.</li>
</ul>

</ac:rich-text-body></ac:macro>

<p>Great!</p>

<p>And is there a way to automatically determine the iec or si, based on Zend_Locale. <br />
Where can I learn this information? <br />
Could it be a part of this component?</p>

<p>Why the name is fileSize if it doesn't get the size of a file.<br />
This component only format binary sizes.</p>

<p>I think it would better to rename this component to Zend_View_Helper_FormatBinary or Zend_View_Helper_FormatBytes</p>

<p>Archived.</p>