Issues

ZF-10643: Zend_Paginator_Adapter_Interface contains commented count()

Issue Type: Bug Created: 2010-11-04T09:39:49.000+0000 Last Updated: 2010-11-08T11:48:27.000+0000 Status: Resolved Fix version(s): - 1.11.1 (30/Nov/10)

Reporter: Jakob Schumann (j-schumann) Assignee: Marc Hodgins (mjh_ca) Tags: - Zend_Paginator

Related issues: Attachments: - ZF-10643.patch

Description

Zend_Paginator_Adapter_Interface contains the method signature and docblock for count() but the signature is commented out.

This is irritating because an IDE would return the docblock for Countable::count(). There should either be a note in the methods or class' docblock why it is commented out, or the method + her docblock should be removed completely or the comment removed.

Comments

Posted by Marc Hodgins (mjh_ca) on 2010-11-05T15:38:40.000+0000

You can't redefine the count() method in the child interface when it has already been defined as abstract in the parent. It throws a PHP fatal error:

<pre class="literal">
PHP Fatal error:  Can't inherit abstract function Countable::count() (previously declared abstract in Zend_Paginator_Adapter_Interface) in /Zend/Paginator/Adapter/Interface.php on line 31

The only solution is as to suggest - remove the commented method signature or explain the comments why it was removed. I've attached a patch to remove it.

Posted by Matthew Weier O'Phinney (matthew) on 2010-11-08T11:48:23.000+0000

Patch applied in trunk and 1.11 release branch.

Have you found an issue?

See the Overview section for more details.

Copyright

© 2006-2016 by Zend, a Rogue Wave Company. Made with by awesome contributors.

This website is built using zend-expressive and it runs on PHP 7.

Contacts