ZF-10795: Zend_Http_UserAgent_Features_Adapter_WurflApi does not properly pass in configuration paramters to Wurfl library

Issue Type: Bug Created: 2010-12-08T09:50:35.000+0000 Last Updated: 2012-06-12T16:45:08.000+0000 Status: Open Fix version(s): Reporter: Jared Ray (jared.ray) Assignee: Business&Decision / Interakting (interakting) Tags: - Zend_Http_UserAgent

Related issues: - ZF-12284

Attachments: - ZF-10795.patch


In Zend_Http_UserAgent_Features_Adapter_WurflApi, the ZF documentation states that a parameter may be used to configure the wurfl adapter with an array using the wurfl_config_array key as part of the UserAgent configuration. The array is passed to the wurfl configuration in the code block below:

<pre class="literal">
    ->persistence($c['persistence']['provider'], $c['persistence']['dir']);

There are a couple issues with this. 1. It does not allow configuration of the "cache provider" for the wurfl library, something that would be nice to have and differs from the "persistence" functionality that is configured here. 2. It does not pass in the dir parameter in correctly for the "persistence" provider. It should be passed as an array with the dir key specified instead of passing the dir parameter in directly. 3. It assumes that we are using a persistence provider that requires a dir parameter, which could very well not be the case, like with Memcache or some other adapter.

For example, to get the wurfl persistence provider to use the dir parameter from a Zend_Config_Xml, one would have to structure it like this:

<pre class="highlight">

```/home/jray/htdocs/newui/application/cache/wurfl/persistence`A better implementation that would also allow for arbitrary parameters to be passed would be something like this:

<pre class="highlight">

/home/jray/htdocs/newui/application/cache/wurfl/persistenceIf the code in Zend_Http_UserAgent_Features_Adapter_WurflApi was changed to something like this it would resolve all of the issues above.

<pre class="literal">
    ->persistence($c['persistence']['provider'], $c['persistence']['params'])
    ->cache($c['cache']['provider'], $c['cache']['params']);


Posted by Jared Ray (jared.ray) on 2010-12-08T09:52:40.000+0000

This patch includes the change mentioned in the description.

Posted by Marc Hodgins (mjh_ca) on 2010-12-08T10:48:32.000+0000

@Jared: Patch needs unit tests to confirm behavior (i.e. 'dir' is currently broken as described in the docs) and then apply your fix and the test should pass. I'm not familiar with this component, but what if the 'cache' parameter is not passed? Also need tests to ensure failing to provide these optional params doesn't break something.

Also is a documentation patched needed to explain the new ability to pass cache information this way?

Posted by Daniel Cousineau (dcousineau) on 2010-12-14T10:24:54.000+0000

The cache section should be checked to see if it exists, but the ->persistence() portion probably needs to at least be pulled off into a separate ticket and fixed immediately given that it a bug (and not a missing feature like cache).

Posted by Daniel Cousineau (dcousineau) on 2010-12-14T10:32:51.000+0000

Actually there's a secondary bug within WURFL itself, while clearly the config should act as described by Jared, WURFL itself has no idea what it wants (WURFL/Xml/PersistenceProvider/PersistenceProviderManager.php line 54).

Posted by Rob Jacoby (craiz) on 2011-02-17T14:13:36.000+0000

Zend\Http\UserAgent\Features\Adapter\WurflApi is in my opinion unfixable for a WURFL 1.1 implementation due to inconsistencies in the WURFL API Config classes.

If we pass the config_array in with the 'dir' param instead of 'params' the API will throw a WURFL_WURFLException with the message: Specify a valid Persistence dir in the configuration file

This is due to the WURFL_Configuration_InMemoryConfig class setting the persistence array with two keys, 'provider' and 'params' (which is the expected use case), however the WURFL_Xml_PersistenceProvider_FilePersistenceProvider initialize function expects the persistence array to have a key of 'dir' which it will never have due to the keys being set forcefully in InMemoryConfig->persistence().

My suggestion would be to remove the ability to configure Wurfl using a wurfl_config_array in Zend\Http\UserAgent\Features\Adapter\WurflApi using WURFL 1.1, and add a switch case for WURFL 1.2 allowing it as the bug has been fixed in this WURFL release.

I have attached a patch to this affect.

Also included in this patch is changes to the UserAgentTest file to remove deprecated assertion assertType and replace it with assertInstanceOf

Posted by Jared Ray (jared.ray) on 2011-03-22T16:11:54.000+0000

Daniel and Rob are correct about the bug in WURFL 1.1. I was using the WURFL 1.2 library and the bug is fixed in version 1.2. I agree with Daniel that the cache section should be checked to see if it exists in the configuration.

Posted by Marcin Gil (mgil) on 2011-04-08T09:41:54.000+0000

For the moment it is possible to use WURLF 1.2.1 with following configuration without altering the code: 'wurflapi' => array ( 'wurfl_api_version' => '1.1', 'wurfl_lib_dir' => BASE_PATH .'/library/WURFL/', 'wurfl_config_array' => array ( 'wurfl' => array ( 'main-file' => $resourcesDir .'', 'patches' => $resourcesDir .'web_browsers_patch.xml', ), 'persistence' => array ( 'provider' => 'file', 'dir' => array('dir' => $cacheDir), ), ) ),

Posted by Henry Hayes (henryhayes) on 2012-06-12T15:59:54.000+0000

I didn't know about this bug and a bug I created today appears to be a duplicate. However after reading through this bug I believe that the fix in this bug report would break anyone's code who has used the workaround mentioned in my bug report and that mentioned on the article.

The fix I have suggested is backward compatible:

Note: My patch also takes into account any other provider/adapter that does not have a "dir" parameter but may have other parameters.

Posted by Henry Hayes (henryhayes) on 2012-06-12T16:02:37.000+0000

Wrong issue linked above, corrected link to "Zend_Http_UserAgent_Features_Adapter_WurflApi Sends Persistence Information using WURFL_Configuration_InMemoryConfig to WURFL_WURFLManagerFactory incorrectly"


Have you found an issue?

See the Overview section for more details.


© 2006-2018 by Zend, a Rogue Wave Company. Made with by awesome contributors.

This website is built using zend-expressive and it runs on PHP 7.