ZF-11394: Testcase has bad doc block that makes auto-complete less efficient

Issue Type: Bug Created: 2011-05-21T12:59:11.000+0000 Last Updated: 2011-07-08T21:18:12.000+0000 Status: Resolved Fix version(s): - 1.11.9 (14/Jul/11)

Reporter: Rafael Machado Dohms (rdohms) Assignee: Rafael Machado Dohms (rdohms) Tags: - Zend_Test_PHPUnit

Related issues: Attachments: - testcase_patch.diff


Zend_Test_PHPUnit_ControllerTestCase class has a bad doc block in getRequest and getResponse.

The doc block reports the return to be a Zend_Controller_Request_Abstract/Zend_Controller_Response_Abstract, when writing tests with this it means the autocomplete does not pickup in specific functions available in the Zend_Controller_Request_HttpTestCase/Zend_Controller_Response_HttpTestCase classes, making auto-complete less efficient.

Since the method always returns a Zend_Controller_Request_HttpTestCase i recommend altering the docblock.


Posted by Rafael Machado Dohms (rdohms) on 2011-05-21T13:00:45.000+0000

I have written a patch for this. I have a CLA but i need to setup my svn env for contributing, this is easier right now.

Posted by Rafael Machado Dohms (rdohms) on 2011-06-11T22:37:24.000+0000

Updated doc blocks

Posted by Rafael Machado Dohms (rdohms) on 2011-07-08T21:17:36.000+0000

Not merged into release-1.11 branch

Posted by Rafael Machado Dohms (rdohms) on 2011-07-08T21:18:12.000+0000

Merged into branch.

Have you found an issue?

See the Overview section for more details.


© 2006-2018 by Zend, a Rogue Wave Company. Made with by awesome contributors.

This website is built using zend-expressive and it runs on PHP 7.