ZF-11470: InfoCard XmlParsingTest has Invalid fail-testcase

Issue Type: Unit Tests: Problem Created: 2011-06-11T00:18:18.000+0000 Last Updated: 2011-08-13T23:46:44.000+0000 Status: Resolved Fix version(s): Reporter: Kazusuke Sasezaki (sasezaki) Assignee: Pádraic Brady (padraic) Tags: - Zend_InfoCard

  • zf-crteam-padraic
  • zf-crteam-priority

Related issues: Attachments:


InfoCard's XmlParsingTest has below's code.

<pre class="highlight">
 public function testKeyInfo() {
    try {
        $this->fail("Expected Exception Not thrown"); 
    } catch(Exception $e) {
     /* yay */

Zend_InfoCard_Xml_KeyInfo::getInstance() method will not throw Exception, if string is as argument?

Please evaluate this above testcase. Is "" valid for KeyInfo?(sorry, I can't judge.)

If "" is valid ,please write assert-testcase for "", and write remove failmethod above.


Posted by Pádraic Brady (padraic) on 2011-08-13T23:45:50.000+0000

The method actually checks for an XML DSig namespace in the given XML string later on and throws an Exception if not found. The test description sucks, but I think that's what it's verifying. Marking as a non-issue as a result.

Thanks for taking the time to report it though!

Have you found an issue?

See the Overview section for more details.


© 2006-2018 by Zend, a Rogue Wave Company. Made with by awesome contributors.

This website is built using zend-expressive and it runs on PHP 7.