ZF-11480: Add the "throws" declaration in PHP Doc

Issue Type: Patch Created: 2011-06-14T18:06:36.000+0000 Last Updated: 2011-06-22T02:08:03.000+0000 Status: Resolved Fix version(s): - 1.11.8 (07/Jul/11)

Reporter: Francescu GAROBY (f.garoby) Assignee: Satoru Yoshida (satoruyoshida) Tags: - Zend_Db

  • add

Related issues: Attachments:


Some functions don't have the "@throws" declaration then they should have ! This patch fixes this.


Posted by Francescu GAROBY (f.garoby) on 2011-06-14T18:13:56.000+0000

diff '--exclude=.original' '--exclude=~' '--exclude=.rej' --ignore-space-change -ruN library.original//Zend/Db/Adapter/Abstract.php library//Zend/Db/Adapter/Abstract.php --- library.original//Zend/Db/Adapter/Abstract.php 2011-06-14 19:59:45.822547994 +0200 +++ library//Zend/Db/Adapter/Abstract.php 2011-06-14 19:59:58.911653520 +0200 @@ -530,6 +530,7 @@ * * @param mixed $table The table to insert data into. * @param array $bind Column-value pairs. + * @throws Zend_Db_Adapter_Exception * @return int The number of affected rows. */ public function insert($table, array $bind) @@ -582,6 +583,7 @@ * @param mixed $table The table to update. * @param array $bind Column-value pairs. * @param mixed $where UPDATE WHERE clause(s). + * @throws Zend_Db_Adapter_Exception * @return int The number of affected rows. */ public function update($table, array $bind, $where = '') diff '--exclude=.original' '--exclude=~' '--exclude=.rej' --ignore-space-change -ruN library.original//Zend/Db/Table/Abstract.php library//Zend/Db/Table/Abstract.php --- library.original//Zend/Db/Table/Abstract.php 2011-06-14 19:59:45.835880415 +0200 +++ library//Zend/Db/Table/Abstract.php 2011-06-14 19:59:58.911653520 +0200 @@ -973,6 +973,7 @@ * otherwise all information is returned as an array. * * @param string $key The specific info part to return OPTIONAL + * @throws Zend_Db_Table_Exception * @return mixed */ public function info($key = null)

Posted by Satoru Yoshida (satoruyoshida) on 2011-06-21T15:14:29.000+0000

Thank You for report, It is solved at SVN r24147. And merged into 1.11 branch at r24148

Posted by Satoru Yoshida (satoruyoshida) on 2011-06-22T02:08:03.000+0000

For any mali sender:

If You find some troubles by this commit, Plz contact with this comment entry.

Do not send SPAMs to my office address (* . (I work ZF NOT in my office, but only in my home)

Have you found an issue?

See the Overview section for more details.


© 2006-2018 by Zend, a Rogue Wave Company. Made with by awesome contributors.

This website is built using zend-expressive and it runs on PHP 7.