ZF-11643: Zend_View_Helper_HeadLink Add Support for Sizes Attribute

Issue Type: Improvement Created: 2011-08-03T18:58:28.000+0000 Last Updated: 2012-06-01T01:24:40.000+0000 Status: Resolved Fix version(s): - 1.12.0 (27/Aug/12)

Reporter: Simon Corless (sico) Assignee: Frank Brückner (frosch) Tags: - Zend_View

  • FixForZF1.12
  • zf-crteam-review

Related issues: Attachments: - HeadLink.php.patch


The view helper Zend_View_Helper_HeadLink should be able to support the sizes attribute in order to facilitate the use of apple touch icons.…

Another idea would be to allow setting custom attributes for use with the headlink helper although the point is possibly to make it fairly strict with the correct doctype but if you could easily add custom items it would allow people to adapt more easily. Currently it involves sub classing the view helper.



### Comments

Posted by Danilo Vorpahl (danilo) on 2012-04-04T10:45:58.000+0000


change line 43 in file "Zend/View/Helper/HeadLink.php" to:

protected $\_itemKeys = array('charset', 'href', 'hreflang', 'id', 'media', 'rel', 'rev', 'type', 'title', 'extras', 'sizes');

hope this will be fixed in the next release, thank you.




Posted by Frank Brückner (frosch) on 2012-04-05T14:06:59.000+0000

Patch und unit test added.



Posted by Adam Lundrigan (adamlundrigan) on 2012-06-01T01:24:40.000+0000

Fixed in trunk (1.12.0): r24858



Have you found an issue?

See the Overview section for more details.


© 2006-2018 by Zend, a Rogue Wave Company. Made with by awesome contributors.

This website is built using zend-expressive and it runs on PHP 7.