Issues

ZF-11900: Zend_Validate_Hostname::ALLOW_ALL does not match documentation

Issue Type: Docs: Problem Created: 2011-11-20T11:09:58.000+0000 Last Updated: 2012-03-09T19:48:17.000+0000 Status: Resolved Fix version(s): - 1.11.12 (22/Jun/12)

Reporter: Holger Schletz (hschletz) Assignee: Adam Lundrigan (adamlundrigan) Tags: - Zend_Validate

  • state:patch-ready-for-review
  • zf-caretaker-adamlundrigan

Related issues: Attachments: - ZF-11900.patch

Description

The manual for Zend_Validate_Hostname says: "For security reasons ALLOW_URI is not contained within ALLOW_ALL." This is not true: ALLOW_ALL is 15, which does contain ALLOW_URI (8). Additionally, the Docstring for both constants says the same: "Allows all types of hostnames".

Either the documentation is incorrect ot ALLOW_ALL should be set to 7 to match the documented behavior.

Comments

Posted by Thomas Weidner (thomas) on 2011-11-20T17:12:03.000+0000

Doc-Problem, code is correct

Posted by Adam Lundrigan (adamlundrigan) on 2011-11-30T18:42:58.000+0000

I've attached a patch which updates this section of the manual to reflect the actual implementation.

Posted by Thomas Weidner (thomas) on 2011-12-03T20:29:21.000+0000

Patch ok. Feel free to commit

Posted by Adam Lundrigan (adamlundrigan) on 2011-12-05T02:08:07.000+0000

Fixed in trunk r24570. Merged to release-1.11 in r24571

Posted by Adam Lundrigan (adamlundrigan) on 2011-12-05T02:41:43.000+0000

ZF2 Pull Request: https://github.com/zendframework/zf2/pull/649

Have you found an issue?

See the Overview section for more details.

Copyright

© 2006-2016 by Zend, a Rogue Wave Company. Made with by awesome contributors.

This website is built using zend-expressive and it runs on PHP 7.

Contacts